Fix name updates on cognito_user_pool_client resource

[jorcau]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7525

Release note for CHANGELOG:

BUG FIXES:

* resource/aws_cognito_user_pool_client: Properly update name value

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCognitoUserPoolClient_ClientName'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCognitoUserPoolClient_ClientName -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCognitoUserPoolClient_ClientName
=== PAUSE TestAccAWSCognitoUserPoolClient_ClientName
=== CONT  TestAccAWSCognitoUserPoolClient_ClientName
--- PASS: TestAccAWSCognitoUserPoolClient_ClientName (47.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	47.232s
...

[bflad]

Thanks so much for this fix and accompanying acceptance test, @jorcau, LGTM. 🚀

--- PASS: TestAccAWSCognitoUserPoolClient_basic (15.26s)
--- PASS: TestAccAWSCognitoUserPoolClient_importBasic (17.08s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFields (18.60s)
--- PASS: TestAccAWSCognitoUserPoolClient_RefreshTokenValidity (24.41s)
--- PASS: TestAccAWSCognitoUserPoolClient_Name (24.48s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField (24.57s)

[bflad]

This has been released in version 2.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests, documentation updates, or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!