Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Support new me-south-1 region in various data sources #9547

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 30, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference: https://github.com/terraform-providers/terraform-provider-aws/blob/master/.github/CONTRIBUTING.md#new-region

Release note for CHANGELOG:

* data-source/aws_cloudtrail_service_account: Support `me-south-1` region
* data-source/aws_elastic_beanstalk_hosted_zone: Support `me-south-1` region
* data-source/aws_elb_hosted_zone_id: Support `me-south-1` region
* data-source/aws_elb_service_account: Support `me-south-1` region
* data-source/aws_s3_bucket: Support `me-south-1` region for `hosted_zone_id` attribute
* resource/aws_s3_bucket: Support `me-south-1` region for `hosted_zone_id` attribute

Output from acceptance testing:

--- PASS: TestAccAWSCloudTrailServiceAccount_basic (11.69s)
--- PASS: TestAccAWSCloudTrailServiceAccount_Region (16.74s)
--- PASS: TestAccAWSElbHostedZoneId_basic (22.28s)
--- PASS: TestAccAWSElbServiceAccount_basic (22.55s)
--- PASS: TestAccAWSDataSourceElasticBeanstalkHostedZone (28.96s)

@bflad bflad requested a review from a team July 30, 2019 14:25
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elb Issues and PRs that pertain to the elb service. labels Jul 30, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 30, 2019
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doubly good on the CONTRIBUTING guide link! This gets three thumbs up 👍 👍 👍

@bflad bflad added this to the v2.22.0 milestone Jul 30, 2019
@bflad bflad merged commit 87f52f9 into master Jul 30, 2019
@bflad bflad deleted the f-me-south-1-data-sources branch July 30, 2019 17:13
bflad added a commit that referenced this pull request Jul 30, 2019
@ghost
Copy link

ghost commented Aug 1, 2019

This has been released in version 2.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elb Issues and PRs that pertain to the elb service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants