-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final retries for various lambda functions #9553
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/L
Managed by automation to categorize the size of a PR.
service/lambda
Issues and PRs that pertain to the lambda service.
labels
Jul 30, 2019
ghost
added
size/M
Managed by automation to categorize the size of a PR.
and removed
size/L
Managed by automation to categorize the size of a PR.
labels
Aug 1, 2019
bflad
reviewed
Aug 1, 2019
bflad
approved these changes
Aug 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (14.77s)
--- PASS: TestAccAWSLambdaFunction_importS3 (32.50s)
--- PASS: TestAccAWSLambdaFunction_versioned (33.33s)
--- PASS: TestAccAWSLambdaFunction_basic (35.11s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_withFunctionName (35.78s)
--- PASS: TestAccAWSLambdaFunction_importLocalFile_VPC (35.80s)
--- PASS: TestAccAWSLambdaFunction_importLocalFile (41.25s)
--- PASS: TestAccAWSLambdaFunction_updateRuntime (46.61s)
--- PASS: TestAccAWSLambdaFunction_concurrency (50.31s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (17.79s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (53.15s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (39.84s)
--- PASS: TestAccAWSLambdaFunction_Layers (25.55s)
--- PASS: TestAccAWSLambdaFunction_envVariables (67.54s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (37.31s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (35.57s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (42.08s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (39.17s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (0.90s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (27.50s)
--- PASS: TestAccAWSLambdaEventSourceMapping_StartingPositionTimestamp (84.29s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_disappears (84.40s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_import (85.76s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (86.49s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (39.01s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_basic (90.14s)
--- PASS: TestAccAWSLambdaFunction_s3 (28.67s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize (91.01s)
--- PASS: TestLambdaPermissionUnmarshalling (0.00s)
--- PASS: TestLambdaPermissionGetQualifierFromLambdaAliasOrVersionArn_alias (0.03s)
--- PASS: TestLambdaPermissionGetQualifierFromLambdaAliasOrVersionArn_govcloud (0.00s)
--- PASS: TestLambdaPermissionGetQualifierFromLambdaAliasOrVersionArn_version (0.00s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (38.46s)
--- PASS: TestLambdaPermissionGetQualifierFromLambdaAliasOrVersionArn_invalid (0.00s)
--- PASS: TestLambdaPermissionGetFunctionNameFromLambdaArn_invalid (0.00s)
--- PASS: TestLambdaPermissionGetFunctionNameFromLambdaArn_valid (0.00s)
--- PASS: TestLambdaPermissionGetFunctionNameFromGovCloudLambdaArn (0.00s)
--- PASS: TestAccAWSLambdaFunction_VPC (45.65s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_basic (92.68s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsDisappears (95.79s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (26.68s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (32.91s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (31.64s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (32.37s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (54.43s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs810 (27.11s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs10x (27.02s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (27.96s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (29.15s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_provided (27.83s)
--- PASS: TestAccAWSLambdaEventSourceMapping_changesInEnabledAreDetected (117.21s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (29.16s)
--- PASS: TestAccAWSLambdaPermission_basic (27.32s)
--- PASS: TestAccAWSLambdaPermission_withRawFunctionName (27.10s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python37 (29.26s)
--- PASS: TestAccAWSLambdaPermission_withStatementIdPrefix (26.96s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby25 (29.38s)
--- PASS: TestAccAWSLambdaPermission_withQualifier (26.44s)
--- PASS: TestAccAWSLambdaPermission_withS3 (25.97s)
--- PASS: TestAccAWSLambdaFunction_tags (41.21s)
--- PASS: TestAccAWSLambdaPermission_withSNS (25.88s)
--- PASS: TestAccAWSLambdaPermission_multiplePerms (32.37s)
--- PASS: TestAccAWSLambdaPermission_withIAMRole (25.35s)
--- PASS: TestAccAWSLambdaPermission_StatementId_Duplicate (83.09s)
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Nov 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
Addresses a defect in current functionality.
service/lambda
Issues and PRs that pertain to the lambda service.
size/M
Managed by automation to categorize the size of a PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates #7873
Release note for CHANGELOG:
Output from acceptance testing: