aws_api_gateway_authorizer: fix authorizer_result_ttl_in_seconds cache disable

[geriBatai]

Null value for authorizer_result_ttl_in_seconds means that API Gateway will use default TTL for authorizer cache, which is 300. Provider was assuming that 0 and null values are the same, causing #705, which made disabling authorization cache impossible. This PR fixes it.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAPIGatewayAuthorizer_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSAPIGatewayAuthorizer_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSAPIGatewayAuthorizer_basic
=== PAUSE TestAccAWSAPIGatewayAuthorizer_basic
=== CONT  TestAccAWSAPIGatewayAuthorizer_basic
--- PASS: TestAccAWSAPIGatewayAuthorizer_basic (55.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	55.172s

$ make testacc TESTARGS='-run=TestAccAWSAPIGatewayAuthorizer_switchAuthorizerTTL'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSAPIGatewayAuthorizer_switchAuthorizerTTL -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSAPIGatewayAuthorizer_switchAuthorizerTTL
=== PAUSE TestAccAWSAPIGatewayAuthorizer_switchAuthorizerTTL
=== CONT  TestAccAWSAPIGatewayAuthorizer_switchAuthorizerTTL
--- PASS: TestAccAWSAPIGatewayAuthorizer_switchAuthorizerTTL (91.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	91.513s

[bflad]

Thanks so much for this fix, @geriBatai, LGTM. 🚀 Setting the attribute default to 300 looks correct in this situation.

--- PASS: TestAccAWSAPIGatewayAuthorizer_cognito (14.11s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_basic (44.79s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_authTypeValidation (81.48s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_switchAuthType (126.50s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_switchAuthorizerTTL (142.93s)

[ghost]

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!