Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final retries after timeouts deleting media resources #9633

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES
* resource/aws_media_package_channel: Final retries after timeouts deleting media package channels
* resource/aws_media_store_container: Final retries after timeouts deleting media store containers

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSMediaPackageChannel"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSMediaPackageChannel -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSMediaPackageChannel_basic
=== PAUSE TestAccAWSMediaPackageChannel_basic
=== RUN   TestAccAWSMediaPackageChannel_description
=== PAUSE TestAccAWSMediaPackageChannel_description
=== RUN   TestAccAWSMediaPackageChannel_tags
=== PAUSE TestAccAWSMediaPackageChannel_tags
=== CONT  TestAccAWSMediaPackageChannel_basic
=== CONT  TestAccAWSMediaPackageChannel_tags
=== CONT  TestAccAWSMediaPackageChannel_description
--- PASS: TestAccAWSMediaPackageChannel_basic (27.00s)
--- PASS: TestAccAWSMediaPackageChannel_description (51.31s)
--- PASS: TestAccAWSMediaPackageChannel_tags (71.51s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       72.348s

make testacc TESTARGS="-run=TestAccAWSMediaStoreContainer"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSMediaStoreContainer -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSMediaStoreContainerPolicy_basic
=== PAUSE TestAccAWSMediaStoreContainerPolicy_basic
=== RUN   TestAccAWSMediaStoreContainerPolicy_import
=== PAUSE TestAccAWSMediaStoreContainerPolicy_import
=== RUN   TestAccAWSMediaStoreContainer_basic
=== PAUSE TestAccAWSMediaStoreContainer_basic
=== RUN   TestAccAWSMediaStoreContainer_tags
=== PAUSE TestAccAWSMediaStoreContainer_tags
=== RUN   TestAccAWSMediaStoreContainer_import
=== PAUSE TestAccAWSMediaStoreContainer_import
=== CONT  TestAccAWSMediaStoreContainerPolicy_basic
=== CONT  TestAccAWSMediaStoreContainer_import
=== CONT  TestAccAWSMediaStoreContainerPolicy_import
=== CONT  TestAccAWSMediaStoreContainer_basic
=== CONT  TestAccAWSMediaStoreContainer_tags
--- PASS: TestAccAWSMediaStoreContainer_basic (144.83s)
--- PASS: TestAccAWSMediaStoreContainerPolicy_import (154.83s)
--- PASS: TestAccAWSMediaStoreContainerPolicy_basic (172.98s)
--- PASS: TestAccAWSMediaStoreContainer_import (180.47s)
--- PASS: TestAccAWSMediaStoreContainer_tags (187.42s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       188.268s

@ryndaniels ryndaniels requested a review from a team August 5, 2019 16:51
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/mediapackage Issues and PRs that pertain to the mediapackage service. service/mediastore Issues and PRs that pertain to the mediastore service. labels Aug 5, 2019
@bflad bflad added the bug Addresses a defect in current functionality. label Aug 6, 2019
@bflad bflad added this to the v2.23.0 milestone Aug 6, 2019
@bflad bflad self-assigned this Aug 6, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSMediaPackageChannel_basic (24.53s)
--- PASS: TestAccAWSMediaPackageChannel_description (25.48s)
--- PASS: TestAccAWSMediaPackageChannel_tags (34.87s)
--- PASS: TestAccAWSMediaStoreContainer_import (89.24s)
--- PASS: TestAccAWSMediaStoreContainer_tags (97.22s)
--- PASS: TestAccAWSMediaStoreContainerPolicy_import (97.58s)
--- PASS: TestAccAWSMediaStoreContainerPolicy_basic (102.58s)
--- PASS: TestAccAWSMediaStoreContainer_basic (128.89s)

@ryndaniels ryndaniels merged commit 0ad1e90 into master Aug 7, 2019
@ryndaniels ryndaniels deleted the rfd-retry-media branch August 7, 2019 12:09
@ghost
Copy link

ghost commented Aug 7, 2019

This has been released in version 2.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/mediapackage Issues and PRs that pertain to the mediapackage service. service/mediastore Issues and PRs that pertain to the mediastore service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants