Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make task_parameters updateable on aws_ssm_maintenance_window_task resource #965

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

PaulAtkins
Copy link
Contributor

Adding ForceNew: true to make task_parameters updateable on aws_ssm_maintenance_window_task resources.

Currently, a plan will correctly detect a change has been made to the parameters, but an apply will fail because the aws_ssm_maintenance_window_task doesn't support update.

Plan

~ aws_ssm_maintenance_window_task.task

    task_parameters.0.values.0: "Write-Host 'Test'" => "Write-Host 'Testing'"

Plan: 0 to add, 1 to change, 0 to destroy.

Apply using v0.9.8

  task_parameters.0.values.0: "Write-Host 'Test'" => "Write-Host 'Testing'"

Error applying plan:

1 error(s) occurred:
* aws_ssm_maintenance_window_task.task: 1 error(s) occurred:
* aws_ssm_maintenance_window_task.task: doesn't support update

@stack72 stack72 added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 26, 2017
@stack72 stack72 merged commit b5e5b03 into hashicorp:master Jun 26, 2017
@stack72
Copy link
Contributor

stack72 commented Jun 26, 2017

Hi @PaulAtkins

Thanks for this - I added an acceptance test to the code to make sure it passes as expected :) This LGTM

Paul

@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants