final retries creating and checking validation for ACM certificates #9661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XS
bflad
suggested changes
Aug 8, 2019
| @@ -80,6 +80,16 @@ func resourceAwsAcmCertificateValidationCreate(d *schema.ResourceData, meta inte | |||
| log.Printf("[INFO] ACM Certificate validation for %s done, certificate was issued", certificate_arn) | |||
| return resource.NonRetryableError(resourceAwsAcmCertificateValidationRead(d, meta)) | |||
| }) | |||
| if isResourceTimeoutError(err) { | |||
| resp, err = acmconn.DescribeCertificate(params) | |||
| if *resp.Certificate.Status != "ISSUED" { | |||
There was a problem hiding this comment.
To prevent potential panics we should prefer to use the AWS Go SDK provided conversion functions and the available ACM service constants for consistency, e.g.
Suggested change
| if *resp.Certificate.Status != "ISSUED" { | |
| if aws.StringValue(resp.Certificate.Status) != acm.CertificateStatusIssued { |
| if isResourceTimeoutError(err) { | ||
| resp, err = acmconn.DescribeCertificate(params) | ||
| if *resp.Certificate.Status != "ISSUED" { | ||
| return fmt.Errorf("Expected certificate to be issued but was in state %s", *resp.Certificate.Status) |
There was a problem hiding this comment.
😎
Suggested change
| return fmt.Errorf("Expected certificate to be issued but was in state %s", *resp.Certificate.Status) | |
| return fmt.Errorf("Expected certificate to be issued but was in state %s", aws.StringValue(resp.Certificate.Status)) |
ghost
added
size/S
bflad
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
LGTM 🚀
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail (10.62s)
--- PASS: TestAccAWSAcmCertificateValidation_timeout (16.68s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdns (122.77s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot (127.35s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard (128.23s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot (133.44s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard (161.73s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan (204.42s)
--- PASS: TestAccAWSAcmCertificateValidation_basic (231.27s)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates #7873
Release note for CHANGELOG:
Output from acceptance testing: