Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final retries after timeouts creating, updating, and deleting dynamodb tables #9697

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_dynamodb_table: Final retries after timeouts creating, updating, and deleting DynamoDB tables

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSDynamoDbTable"   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDynamoDbTable -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDynamoDbTableItem_basic
=== PAUSE TestAccAWSDynamoDbTableItem_basic
=== RUN   TestAccAWSDynamoDbTableItem_rangeKey
=== PAUSE TestAccAWSDynamoDbTableItem_rangeKey
=== RUN   TestAccAWSDynamoDbTableItem_withMultipleItems
=== PAUSE TestAccAWSDynamoDbTableItem_withMultipleItems
=== RUN   TestAccAWSDynamoDbTableItem_update
=== PAUSE TestAccAWSDynamoDbTableItem_update
=== RUN   TestAccAWSDynamoDbTableItem_updateWithRangeKey
=== PAUSE TestAccAWSDynamoDbTableItem_updateWithRangeKey
=== RUN   TestAccAWSDynamoDbTable_importBasic
=== PAUSE TestAccAWSDynamoDbTable_importBasic
=== RUN   TestAccAWSDynamoDbTable_importTags
=== PAUSE TestAccAWSDynamoDbTable_importTags
=== RUN   TestAccAWSDynamoDbTable_basic
=== PAUSE TestAccAWSDynamoDbTable_basic
=== RUN   TestAccAWSDynamoDbTable_disappears
=== PAUSE TestAccAWSDynamoDbTable_disappears
=== RUN   TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI
=== PAUSE TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI
=== RUN   TestAccAWSDynamoDbTable_extended
=== PAUSE TestAccAWSDynamoDbTable_extended
=== RUN   TestAccAWSDynamoDbTable_enablePitr
=== PAUSE TestAccAWSDynamoDbTable_enablePitr
=== RUN   TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned
=== PAUSE TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned
=== RUN   TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest
=== PAUSE TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest
=== RUN   TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned
=== PAUSE TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned
=== RUN   TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest
=== PAUSE TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest
=== RUN   TestAccAWSDynamoDbTable_streamSpecification
=== PAUSE TestAccAWSDynamoDbTable_streamSpecification
=== RUN   TestAccAWSDynamoDbTable_streamSpecificationValidation
=== PAUSE TestAccAWSDynamoDbTable_streamSpecificationValidation
=== RUN   TestAccAWSDynamoDbTable_tags
=== PAUSE TestAccAWSDynamoDbTable_tags
=== RUN   TestAccAWSDynamoDbTable_gsiUpdateCapacity
=== PAUSE TestAccAWSDynamoDbTable_gsiUpdateCapacity
=== RUN   TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes
=== PAUSE TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes
=== RUN   TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes
=== PAUSE TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes
=== RUN   TestAccAWSDynamoDbTable_Ttl_Enabled
=== PAUSE TestAccAWSDynamoDbTable_Ttl_Enabled
=== RUN   TestAccAWSDynamoDbTable_Ttl_Disabled
=== PAUSE TestAccAWSDynamoDbTable_Ttl_Disabled
=== RUN   TestAccAWSDynamoDbTable_attributeUpdate
=== PAUSE TestAccAWSDynamoDbTable_attributeUpdate
=== RUN   TestAccAWSDynamoDbTable_attributeUpdateValidation
=== PAUSE TestAccAWSDynamoDbTable_attributeUpdateValidation
=== RUN   TestAccAWSDynamoDbTable_encryption
=== PAUSE TestAccAWSDynamoDbTable_encryption
=== CONT  TestAccAWSDynamoDbTableItem_basic
=== CONT  TestAccAWSDynamoDbTable_encryption
=== CONT  TestAccAWSDynamoDbTable_importTags
=== CONT  TestAccAWSDynamoDbTableItem_updateWithRangeKey
=== CONT  TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest
=== CONT  TestAccAWSDynamoDbTable_attributeUpdateValidation
=== CONT  TestAccAWSDynamoDbTable_attributeUpdate
=== CONT  TestAccAWSDynamoDbTable_Ttl_Disabled
=== CONT  TestAccAWSDynamoDbTable_Ttl_Enabled
=== CONT  TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes
=== CONT  TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes
=== CONT  TestAccAWSDynamoDbTable_gsiUpdateCapacity
=== CONT  TestAccAWSDynamoDbTable_tags
=== CONT  TestAccAWSDynamoDbTable_streamSpecificationValidation
=== CONT  TestAccAWSDynamoDbTable_streamSpecification
=== CONT  TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest
=== CONT  TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned
=== CONT  TestAccAWSDynamoDbTableItem_update
=== CONT  TestAccAWSDynamoDbTable_importBasic
=== CONT  TestAccAWSDynamoDbTableItem_withMultipleItems
=== CONT  TestAccAWSDynamoDbTable_basic
--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (8.83s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (11.01s)
=== CONT  TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned
--- PASS: TestAccAWSDynamoDbTable_importTags (77.27s)
=== CONT  TestAccAWSDynamoDbTable_enablePitr
--- PASS: TestAccAWSDynamoDbTableItem_updateWithRangeKey (77.60s)
=== CONT  TestAccAWSDynamoDbTable_extended
--- PASS: TestAccAWSDynamoDbTableItem_update (100.43s)
=== CONT  TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI
--- PASS: TestAccAWSDynamoDbTableItem_basic (140.60s)
=== CONT  TestAccAWSDynamoDbTable_disappears
--- PASS: TestAccAWSDynamoDbTableItem_withMultipleItems (140.78s)
=== CONT  TestAccAWSDynamoDbTableItem_rangeKey
--- PASS: TestAccAWSDynamoDbTable_basic (132.64s)
--- PASS: TestAccAWSDynamoDbTable_importBasic (157.16s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Disabled (166.09s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (177.04s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (181.10s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned (174.30s)
--- PASS: TestAccAWSDynamoDbTable_tags (185.87s)
--- PASS: TestAccAWSDynamoDbTable_disappears (81.86s)
--- PASS: TestAccAWSDynamoDbTable_extended (149.93s)
--- PASS: TestAccAWSDynamoDbTableItem_rangeKey (104.41s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (262.79s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Enabled (294.62s)
--- PASS: TestAccAWSDynamoDbTable_encryption (296.62s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned (331.55s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest (392.44s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (325.77s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest (474.39s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (566.85s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (567.48s)
--- PASS: TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI (496.90s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       598.554s

@ryndaniels ryndaniels requested a review from a team August 9, 2019 10:56
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/dynamodb Issues and PRs that pertain to the dynamodb service. labels Aug 9, 2019
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Aug 9, 2019
@ryndaniels ryndaniels added this to the v2.24.0 milestone Aug 9, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (7.32s)
--- PASS: TestAccAWSDynamoDbTableItem_withMultipleItems (25.43s)
--- PASS: TestAccAWSDynamoDbTable_disappears (25.70s)
--- PASS: TestAccAWSDynamoDbTableItem_basic (28.96s)
--- PASS: TestAccAWSDynamoDbTableItem_rangeKey (31.21s)
--- PASS: TestAccAWSDynamoDbTable_basic (32.09s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (3.64s)
--- PASS: TestAccAWSDynamoDbTableItem_updateWithRangeKey (122.37s)
--- PASS: TestAccAWSDynamoDbTableItem_update (123.72s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (128.99s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned (136.41s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Enabled (113.88s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned (145.32s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Disabled (118.59s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (165.19s)
--- PASS: TestAccAWSDynamoDbTable_importBasic (168.49s)
--- PASS: TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI (196.76s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (222.52s)
--- PASS: TestAccAWSDynamoDbTable_encryption (227.87s)
--- PASS: TestAccAWSDynamoDbTable_extended (275.01s)
--- PASS: TestAccAWSDynamoDbTable_tags (277.51s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (286.84s)
--- PASS: TestAccAWSDynamoDbTable_importTags (539.24s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (581.76s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (559.68s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest (699.17s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest (766.93s)

@ryndaniels ryndaniels merged commit 972a22a into master Aug 12, 2019
@ryndaniels ryndaniels deleted the rfd-retry-dynamo branch August 12, 2019 11:32
@ghost
Copy link

ghost commented Aug 15, 2019

This has been released in version 2.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants