Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final retries for gamelift resources #9752

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Final retries for gamelift resources #9752

merged 1 commit into from
Aug 14, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_gamelift_build: Final retry after timeout creating gamelift build
* resource/aws_gamelift fleet: Final retry after timeout deleting gamelift fleet

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSGameliftFleet"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSGameliftFleet -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSGameliftFleet_basic
=== PAUSE TestAccAWSGameliftFleet_basic
=== RUN   TestAccAWSGameliftFleet_allFields
=== PAUSE TestAccAWSGameliftFleet_allFields
=== CONT  TestAccAWSGameliftFleet_basic
=== CONT  TestAccAWSGameliftFleet_allFields
--- PASS: TestAccAWSGameliftFleet_basic (1366.75s)
--- PASS: TestAccAWSGameliftFleet_allFields (1393.92s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1395.181s

 make testacc TESTARGS="-run=TestAccAWSGameliftBuild"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSGameliftBuild -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSGameliftBuild_basic
=== PAUSE TestAccAWSGameliftBuild_basic
=== CONT  TestAccAWSGameliftBuild_basic
--- PASS: TestAccAWSGameliftBuild_basic (42.45s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       43.626s

@ryndaniels ryndaniels requested a review from a team August 13, 2019 12:45
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/gamelift Issues and PRs that pertain to the gamelift service. labels Aug 13, 2019
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Aug 13, 2019
@ryndaniels ryndaniels added this to the v2.24.0 milestone Aug 13, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ryndaniels ryndaniels merged commit 76fefe7 into master Aug 14, 2019
@ryndaniels ryndaniels deleted the rfd-retry-gamelift branch August 14, 2019 09:58
@ghost
Copy link

ghost commented Aug 15, 2019

This has been released in version 2.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/gamelift Issues and PRs that pertain to the gamelift service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants