s3_bucket_notification: Fix not create bucket field when import

[kjmkznr]

Fixes #895

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSS3BucketNotification_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSS3BucketNotification_ -timeout 120m
=== RUN   TestAccAWSS3BucketNotification_importBasic
--- PASS: TestAccAWSS3BucketNotification_importBasic (117.69s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       117.704s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSS3Bucket_Notification'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSS3Bucket_Notification -timeout 120m
=== RUN   TestAccAWSS3Bucket_Notification
--- PASS: TestAccAWSS3Bucket_Notification (190.11s)
=== RUN   TestAccAWSS3Bucket_NotificationWithoutFilter
--- PASS: TestAccAWSS3Bucket_NotificationWithoutFilter (70.96s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       261.088s

[radeksimko]

Hi @kjmkznr
would you mind also modifying acceptance tests to reflect this bugfix? At the moment the field is being ignored there, which is likely the reason this bug was actually not discovered by a test failure.

See all the ImportStateVerifyIgnore in https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/import_aws_s3_bucket_notification_test.go - I think they can all (3) go away.

Thanks.

[kjmkznr]

@radeksimko
Thanks comment.
Fix import acceptance tests.

bucket attribute in ImportStateVerifyIgnore, It is probably my mistake that...

[radeksimko]

LGTM. Thanks

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!