Fixed remnant CloudWatch Dashboards on each dashboard rename

[JamesPeiris]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9782

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudWatchDashboard_updateName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSCloudWatchDashboard_updateName -timeout 120m
=== RUN   TestAccAWSCloudWatchDashboard_updateName
=== PAUSE TestAccAWSCloudWatchDashboard_updateName
=== CONT  TestAccAWSCloudWatchDashboard_updateName
--- PASS: TestAccAWSCloudWatchDashboard_updateName (35.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	35.384s
...

FYI:

$ make testacc TESTARGS='-run=TestAccXXX'

Without the TEST=./aws env var also set results in:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCloudWatchDashboard_updateName -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]

Which hangs until killed.

Thanks in advance!

[bflad]

Hi @JamesPeiris 👋 Thank you for submitting this fix.

Usually in these situations it is easiest to just add ForceNew: true to the problematic schema attribute (dashboard_name in this case), which should hopefully eliminate most, if not all the other changes since Terraform will automatically plan on destroying the old dashboard and creating a new dashboard.

Can you please try updating this pull request with that instead? Thanks. 👍

[JamesPeiris]

Hello @bflad 👋

Thank you for taking the time to look at this, I appreciate that your time must be spread quite thinly!

I have amended the implementation as per your suggestion, which I have tested and works as expected - would you be able to take another look at this please?

Thanks again, and happy new year 🎉

[bflad]

Thanks so much for the update, @JamesPeiris 🚀 One minor testing fix on merge, which I will take care of for you.

Output from acceptance testing after testing fix:

--- PASS: TestAccAWSCloudWatchDashboard_basic (19.86s)
--- PASS: TestAccAWSCloudWatchDashboard_updateName (31.01s)
--- PASS: TestAccAWSCloudWatchDashboard_update (33.48s)

[bflad]

Likely copy-paste from the earlier iteration of this pull request, the test configuration resource name is aws_cloudwatch_dashboard.test:

https://github.com/terraform-providers/terraform-provider-aws/blob/e1fc857056e66b257520f73ca5e22dc6facaebef/aws/resource_aws_cloudwatch_dashboard_test.go#L159

Otherwise, this test causes this error:

--- FAIL: TestAccAWSCloudWatchDashboard_updateName (5.64s)
    testing.go:640: Step 0 error: Check failed: Check 1/3 error: Not found: aws_cloudwatch_dashboard.foobar

Since it is a small testing fix, will do so on merge. 👍

[JamesPeiris]

Gah, I was so close. Thanks!

[ghost]

This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!