Final sagemaker retries

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES
* resource/aws_sagemaker_model: Final retry after timeout deleting model
* resource/aws_sagemaker_notebook_instance: Final retry after timeout updating instance

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSSagemakerModel"       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSagemakerModel -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSagemakerModel_basic
=== PAUSE TestAccAWSSagemakerModel_basic
=== RUN   TestAccAWSSagemakerModel_tags
=== PAUSE TestAccAWSSagemakerModel_tags
=== RUN   TestAccAWSSagemakerModel_primaryContainerModelDataUrl
=== PAUSE TestAccAWSSagemakerModel_primaryContainerModelDataUrl
=== RUN   TestAccAWSSagemakerModel_primaryContainerHostname
=== PAUSE TestAccAWSSagemakerModel_primaryContainerHostname
=== RUN   TestAccAWSSagemakerModel_primaryContainerEnvironment
=== PAUSE TestAccAWSSagemakerModel_primaryContainerEnvironment
=== RUN   TestAccAWSSagemakerModel_containers
=== PAUSE TestAccAWSSagemakerModel_containers
=== RUN   TestAccAWSSagemakerModel_vpcConfig
=== PAUSE TestAccAWSSagemakerModel_vpcConfig
=== RUN   TestAccAWSSagemakerModel_networkIsolation
=== PAUSE TestAccAWSSagemakerModel_networkIsolation
=== CONT  TestAccAWSSagemakerModel_basic
=== CONT  TestAccAWSSagemakerModel_containers
=== CONT  TestAccAWSSagemakerModel_primaryContainerEnvironment
=== CONT  TestAccAWSSagemakerModel_networkIsolation
=== CONT  TestAccAWSSagemakerModel_primaryContainerHostname
=== CONT  TestAccAWSSagemakerModel_primaryContainerModelDataUrl
=== CONT  TestAccAWSSagemakerModel_tags
=== CONT  TestAccAWSSagemakerModel_vpcConfig
--- PASS: TestAccAWSSagemakerModel_primaryContainerEnvironment (45.14s)
--- PASS: TestAccAWSSagemakerModel_networkIsolation (48.30s)
--- PASS: TestAccAWSSagemakerModel_basic (52.88s)
--- PASS: TestAccAWSSagemakerModel_containers (57.61s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerHostname (66.31s)
--- PASS: TestAccAWSSagemakerModel_vpcConfig (67.07s)
--- PASS: TestAccAWSSagemakerModel_tags (69.60s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerModelDataUrl (84.11s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       85.215s

make testacc TESTARGS="-run=TestAccAWSSagemakerNotebookInstance"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSagemakerNotebookInstance -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_Basic
=== PAUSE TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_Basic
=== RUN   TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_Update
=== PAUSE TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_Update
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_update
=== PAUSE TestAccAWSSagemakerNotebookInstance_update
=== RUN   TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== PAUSE TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== RUN   TestAccAWSSagemakerNotebookInstance_tags
=== PAUSE TestAccAWSSagemakerNotebookInstance_tags
=== RUN   TestAccAWSSagemakerNotebookInstance_disappears
=== PAUSE TestAccAWSSagemakerNotebookInstance_disappears
=== CONT  TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_Basic
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_update
=== CONT  TestAccAWSSagemakerNotebookInstance_tags
=== CONT  TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== CONT  TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_Update
--- PASS: TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_Basic (26.17s)
--- PASS: TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_Update (44.28s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (272.94s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (310.80s)
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (341.28s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (369.65s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (568.52s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       569.662s

[bflad]

LGTM 🚀

(test failure unrelated)

--- PASS: TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_Basic (11.00s)
--- PASS: TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_Update (15.58s)
--- FAIL: TestAccAWSSagemakerModel_tags (21.84s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerHostname (25.71s)
--- PASS: TestAccAWSSagemakerModel_vpcConfig (28.04s)
--- PASS: TestAccAWSSagemakerModel_containers (29.97s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerModelDataUrl (39.68s)
--- PASS: TestAccAWSSagemakerModel_basic (40.71s)
--- PASS: TestAccAWSSagemakerModel_networkIsolation (45.71s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerEnvironment (46.14s)
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (282.61s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (291.34s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (300.53s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (305.88s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (607.55s)

[ghost]

This has been released in version 2.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!