aws_vpc_endpoint_service - Use Filter instead of ServiceNames

[jaredledvina]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

aws_vpc_endpoint_service - Query via Filters for service-names instead of ServiceNames

us-east-1 currently fails to have the s3 service endpoint returned when used in this fashion. This switches the code to using filters which works in us-east-1 and the other regions.

As of 6:26:30 PM EST on Tuesday, November 12, 2019:

❯ aws ec2 describe-vpc-endpoint-services --service-names "com.amazonaws.us-east-1.s3"

An error occurred (InvalidServiceName) when calling the DescribeVpcEndpointServices operation: The Vpc Endpoint Service 'com.amazonaws.us-east-1.s3' does not exist

Whereas the filter expression works:

❯ aws ec2 describe-vpc-endpoint-services --filter "Name=service-name,Values=com.amazonaws.us-east-1.s3"
{
    "ServiceDetails": [
        {
            "ServiceName": "com.amazonaws.us-east-1.s3",
            "ServiceId": "vpce-svc-1234567890",
            "ServiceType": [
                {
                    "ServiceType": "Gateway"
                }
            ],
            "AvailabilityZones": [
                "us-east-1a",
                "us-east-1b",
                "us-east-1c",
                "us-east-1d",
                "us-east-1e",
                "us-east-1f"
            ],
            "Owner": "amazon",
            "BaseEndpointDnsNames": [
                "s3.us-east-1.amazonaws.com"
            ],
            "VpcEndpointPolicySupported": true,
            "AcceptanceRequired": false,
            "ManagesVpcEndpoints": false,
            "Tags": []
        }
    ],
    "ServiceNames": [
        "com.amazonaws.us-east-1.s3"
    ]
}

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
TODO

[jaredledvina]

Noting here, the issue on the AWS side has been resolved. I think this PR can still go in but, is no longer required.

[bflad]

Hi @jaredledvina 👋 Thank you for submitting this. Our general preference is to have Terraform resource arguments match the underlying API request structure, so operators do not need to know about any special translation that might be occurring within Terraform. This data source should support filter configuration blocks, similar to other EC2 data sources and an issue has been created in that regard: #11994

Since the underlying API issue has been resolved (so there's no bug to fix), there's no additional upvotes to this pull request, and there's a tracking issue for future enhancement work, I'm going to close this. Thank you again.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!