Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ca_cert_identifier for aws_rds_cluster_instance #10954

Merged
merged 1 commit into from
Dec 21, 2019
Merged

Added ca_cert_identifier for aws_rds_cluster_instance #10954

merged 1 commit into from
Dec 21, 2019

Conversation

awsiv
Copy link
Contributor

@awsiv awsiv commented Nov 20, 2019

Allows updating ca_cert_identifier for aws_rds_cluster_instance resource

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10467 #10517
Relates #10417

Release note for CHANGELOG:

Allow updating ca_cert_identifier for aws_rds_cluster_instance

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSRDSClusterInstance_CACertificateIdentifier'
==> Checking that code complies with gofmt requirements...

TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSRDSClusterInstance_CACertificateIdentifier -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]

=== RUN   TestAccAWSRDSClusterInstance_CACertificateIdentifier
=== PAUSE TestAccAWSRDSClusterInstance_CACertificateIdentifier
=== CONT  TestAccAWSRDSClusterInstance_CACertificateIdentifier
--- PASS: TestAccAWSRDSClusterInstance_CACertificateIdentifier (828.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	828.047s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.010s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.018s [no tests to run]
...

@awsiv awsiv requested a review from a team November 20, 2019 20:11
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 20, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 21, 2019
@marcoreni
Copy link
Contributor

Is there a chance to get this checked&merged soon? The "aws_db_instance" changes have been merged in 2.37, it would be helpful to support cluster_instance as well

@awsiv
Copy link
Contributor Author

awsiv commented Dec 2, 2019

@gdavison Any chances you could look into this please? :)

Notification from AWS: https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.SSL-certificate-rotation.html

The current CA certificates expire on March 5, 2020. Therefore, we strongly recommend completing this change as soon as possible (and no later than February 5, 2020), to avoid disruption on the expiration date. If the change is not completed, your applications will fail to connect to your RDS DB instances using SSL/TLS after March 5, 2020.

@rryke
Copy link

rryke commented Dec 12, 2019

any update on this pr?

@lifeofguenter
Copy link

Sorry for spamming but any updates???

@rspljignesh
Copy link

Hello,

We are eagerly waiting this PR to be reviewed and we have new release at earliest.

Thanks

Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraPostgresql (690.55s)
--- PASS: TestAccAWSRDSClusterInstance_PubliclyAccessible (697.56s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql (701.49s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql1 (731.76s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2_DefaultKeyToCustomKey (744.70s)
--- PASS: TestAccAWSRDSClusterInstance_kmsKey (762.18s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1 (772.44s)
--- PASS: TestAccAWSRDSClusterInstance_disappears (807.00s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1_DefaultKeyToCustomKey (835.59s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql2 (852.27s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2 (853.78s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToDisabled (1034.84s)
--- PASS: TestAccAWSRDSClusterInstance_CopyTagsToSnapshot (1132.85s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToRemoved (1153.96s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringInterval (1280.48s)
--- PASS: TestAccAWSRDSClusterInstance_CACertificateIdentifier (681.94s)
--- PASS: TestAccAWSRDSClusterInstance_basic (1415.39s)
--- PASS: TestAccAWSRDSClusterInstance_namePrefix (1422.91s)
--- PASS: TestAccAWSRDSClusterInstance_generatedName (1441.49s)
--- PASS: TestAccAWSRDSClusterInstance_az (1521.35s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql_DefaultKeyToCustomKey (841.07s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_RemovedToEnabled (1645.89s)

@gdavison gdavison merged commit 85f357c into hashicorp:master Dec 21, 2019
@gdavison gdavison added this to the v2.44.0 milestone Dec 21, 2019
gdavison added a commit that referenced this pull request Dec 21, 2019
@sabbirahmed007
Copy link

hi, sorry this maybe a silly question to ask but the ca_cert_identifier is this support for terraform 0.11.13? with aws provider 2.44.0 or will this only work for terraform 0.12.X

@gdavison
Copy link
Contributor

gdavison commented Jan 6, 2020

@sabbirahmed007, version 2.x of the AWS provider works with Terraform 0.11. Please note that 0.11 is deprecated, and we strongly encourage you to update to Terraform 0.12.

For reference: https://www.terraform.io/upgrade-guides/0-12.html

@ckuehl
Copy link

ckuehl commented Jan 6, 2020

Is there a planned release date for v2.44.0? We have less than a month to update before the February 5th deadline on the AWS side and would like to make this change ASAP.

@gdavison
Copy link
Contributor

gdavison commented Jan 7, 2020

Yes. We aim for weekly releases, and are just back from a two-week break. v2.44.0 should be released this week

@ghost
Copy link

ghost commented Jan 10, 2020

This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_rds_cluster_instance should support ca_cert_identifier
9 participants