-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ca_cert_identifier for aws_rds_cluster_instance #10954
Conversation
Is there a chance to get this checked&merged soon? The "aws_db_instance" changes have been merged in 2.37, it would be helpful to support cluster_instance as well |
@gdavison Any chances you could look into this please? :) Notification from AWS: https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.SSL-certificate-rotation.html
|
any update on this pr? |
Sorry for spamming but any updates??? |
Hello, We are eagerly waiting this PR to be reviewed and we have new release at earliest. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraPostgresql (690.55s)
--- PASS: TestAccAWSRDSClusterInstance_PubliclyAccessible (697.56s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql (701.49s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql1 (731.76s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2_DefaultKeyToCustomKey (744.70s)
--- PASS: TestAccAWSRDSClusterInstance_kmsKey (762.18s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1 (772.44s)
--- PASS: TestAccAWSRDSClusterInstance_disappears (807.00s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1_DefaultKeyToCustomKey (835.59s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql2 (852.27s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2 (853.78s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToDisabled (1034.84s)
--- PASS: TestAccAWSRDSClusterInstance_CopyTagsToSnapshot (1132.85s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToRemoved (1153.96s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringInterval (1280.48s)
--- PASS: TestAccAWSRDSClusterInstance_CACertificateIdentifier (681.94s)
--- PASS: TestAccAWSRDSClusterInstance_basic (1415.39s)
--- PASS: TestAccAWSRDSClusterInstance_namePrefix (1422.91s)
--- PASS: TestAccAWSRDSClusterInstance_generatedName (1441.49s)
--- PASS: TestAccAWSRDSClusterInstance_az (1521.35s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql_DefaultKeyToCustomKey (841.07s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_RemovedToEnabled (1645.89s)
hi, sorry this maybe a silly question to ask but the ca_cert_identifier is this support for terraform 0.11.13? with aws provider 2.44.0 or will this only work for terraform 0.12.X |
@sabbirahmed007, version 2.x of the AWS provider works with Terraform 0.11. Please note that 0.11 is deprecated, and we strongly encourage you to update to Terraform 0.12. For reference: https://www.terraform.io/upgrade-guides/0-12.html |
Is there a planned release date for v2.44.0? We have less than a month to update before the February 5th deadline on the AWS side and would like to make this change ASAP. |
Yes. We aim for weekly releases, and are just back from a two-week break. v2.44.0 should be released this week |
This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Allows updating ca_cert_identifier for aws_rds_cluster_instance resource
Community Note
Closes #10467 #10517
Relates #10417
Release note for CHANGELOG:
Output from acceptance testing: