Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait longer for ACM certificates creation. #12371

Merged
merged 1 commit into from
May 27, 2020
Merged

Wait longer for ACM certificates creation. #12371

merged 1 commit into from
May 27, 2020

Conversation

gilbsgilbs
Copy link
Contributor

@gilbsgilbs gilbsgilbs commented Mar 12, 2020 •
edited
Loading

When an ACM certificate has a lot of SANs (>20), it takes more
than 1 minute for AWS to generate all the DNS challenges. This PR
will make the resource wait for the challenges 5 minutes instead of
1 minute.

Closes #12445

@gilbsgilbs
Wait longer for ACM certificates.
a4f42fa 
When an ACM certificate has a lot of SANs (>20), it takes more
than 1 minute to AWS to generate all the challenges. This waits for the
challenges 5 minutes instead of 1 minute.
@gilbsgilbs gilbsgilbs requested a review from a team March 12, 2020 17:39
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/acm Issues and PRs that pertain to the acm service. labels Mar 12, 2020
@mattburgess
Copy link
Collaborator

Closes #12445

@georgekaz
Copy link

Hi. Do we know when this is going to be merged? Currently stuck with this exact problem. Thanks

@gilbsgilbs
Copy link
Contributor Author

@bflad Could you or somebody from the team have a look? I think this PR is very trivial and might be beneficial to a few of us. (Sorry for the mention I don't like to be that guy 🤐 .)

@georgekaz
Copy link

Just had to apply a horrible workaround. Run the terraform. let it fail. Remove the item from tf state. Wait for the cert to be ready in the console. Get the arn. Re-import into tf state

@bflad bflad mentioned this pull request May 18, 2020
Closed
@bflad bflad added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels May 27, 2020
@bflad bflad added this to the v2.64.0 milestone May 27, 2020
@bflad bflad linked an issue May 27, 2020 that may be closed by this pull request
aws_acm_certificate appears to be waiting for DNS validation to complete when SANs are present #8530
Closed
bflad
bflad approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gilbsgilbs 👋 Thank you for fixing this. This seems like the correct adjustment in this case (barring any AWS documentation on how long this process may possibly take). 🚀 I have marked this to also close the older #8530. 👍

@bflad bflad merged commit 5ced3d4 into hashicorp:master May 27, 2020
bflad added a commit that referenced this pull request May 27, 2020
@bflad
Update CHANGELOG for #12371
98df32d
@ghost
Copy link

ghost commented May 29, 2020

This has been released in version 2.64.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jun 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/acm Issues and PRs that pertain to the acm service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.64.0
4 participants
@gilbsgilbs @mattburgess @georgekaz @bflad