Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for application templates and creating applications from a template #554

Merged
merged 7 commits into from
Sep 7, 2021

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Sep 6, 2021

  • New Data Source: azuread_application_template
  • azuread_application - support for the template_id property for creating applications from a template

This PR adds a data source for the Azure AD App Gallery, and support for instantiating new app registrations from a template in said gallery. It also adds tests to ensure support for managing service principals for applications that were created from a template (i.e. making use of use_existing), since instantiating a gallery application causes an app registration and service principal to be created in the background.

Some documentation sprucing to add examples for the various supported use cases of creating your own app, instantiating from a gallery app (e.g. Marketo), or assigning access to a first-party MS application (e.g. MS Graph).

Closes: #458

@manicminer manicminer added this to the v2.2.0 milestone Sep 6, 2021
@manicminer manicminer requested a review from a team September 6, 2021 22:16
@manicminer manicminer force-pushed the feature/application-from-template branch 2 times, most recently from 042f4d9 to f9fcc4b Compare September 6, 2021 22:26
@manicminer manicminer force-pushed the feature/application-from-template branch from f9fcc4b to 1301c67 Compare September 7, 2021 11:36
Copy link

@koikonom koikonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manicminer
Copy link
Contributor Author

Test results

Screenshot 2021-09-07 at 15 46 29
Screenshot 2021-09-07 at 15 48 33

@manicminer manicminer merged commit b0f0913 into main Sep 7, 2021
@manicminer manicminer deleted the feature/application-from-template branch September 7, 2021 14:49
manicminer added a commit that referenced this pull request Sep 7, 2021
@github-actions
Copy link

This functionality has been released in v2.2.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

applicationTemplateId field is missing in azuread_application
2 participants