Ignore order for reply_urls #61
Conversation
cgroschupp
force-pushed
the
feature/fix_reply_urls_order
branch
from
e9c7865 to
f811277
Compare
There was a problem hiding this comment.
Thanks for the PR @cgroschupp, order definitely shouldn't matter here.
This LGTM except you are going to need to update an acceptance test:
------- Stdout: -------
=== RUN TestAccAzureADApplication_update
=== PAUSE TestAccAzureADApplication_update
=== CONT TestAccAzureADApplication_update
--- FAIL: TestAccAzureADApplication_update (3.94s)
testing.go:538: Step 1 error: Check failed: Check 7/8 error: azuread_application.test: Attribute 'reply_urls.0' not found
FAIL
|
@katbyte I haven't found a solution except to set reply_url to a fixed string to get a static set ID. I hope that's okay. |
There was a problem hiding this comment.
Thats perfect @cgroschupp 🙂 that you for making that change. LGTM 🚀
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Use TypeSet for reply_urls to ignore order.