Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/application app roles #98

Merged
merged 14 commits into from
Jun 12, 2019

Conversation

steve-hawkins
Copy link
Contributor

this should resolve #75

@ghost ghost added size/XL and removed size/L labels Jun 7, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @steve-hawkins,

I've left some comments inline, nothing major. Once those are addressed and tests pass this should be good to merge!

azuread/resource_application.go Outdated Show resolved Hide resolved
azuread/resource_application.go Outdated Show resolved Hide resolved
azuread/resource_application.go Outdated Show resolved Hide resolved
website/docs/r/application.html.markdown Show resolved Hide resolved
azuread/resource_application.go Show resolved Hide resolved
azuread/resource_application.go Outdated Show resolved Hide resolved
azuread/resource_application.go Outdated Show resolved Hide resolved
@katbyte katbyte added this to the v1.0.0 milestone Jun 10, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @steve-hawkins, i've left some comments outlining how to move the casts into the expand function.

I don't think a check is actually needed looking at some other code. Once these are addressed this should be good to merge 🙂

azuread/resource_application.go Show resolved Hide resolved
azuread/resource_application.go Outdated Show resolved Hide resolved
azuread/resource_application.go Outdated Show resolved Hide resolved
azuread/resource_application.go Outdated Show resolved Hide resolved
azuread/resource_application.go Show resolved Hide resolved
azuread/resource_application.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! LGTM 👍

@katbyte katbyte merged commit d1c18e8 into hashicorp:master Jun 12, 2019
katbyte added a commit that referenced this pull request Jun 12, 2019
@ghost
Copy link

ghost commented Jul 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 13, 2019
@ghost ghost removed the waiting-response label Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azuread_application: Add support for custom app roles
2 participants