New Data Source: azurerm_app_service
#1071
Conversation
``` $ acctests azurerm TestAccDataSourceAzureRMAppService_ === RUN TestAccDataSourceAzureRMAppService_basic --- PASS: TestAccDataSourceAzureRMAppService_basic (253.82s) === RUN TestAccDataSourceAzureRMAppService_tags --- PASS: TestAccDataSourceAzureRMAppService_tags (111.16s) === RUN TestAccDataSourceAzureRMAppService_clientAppAffinityDisabled --- PASS: TestAccDataSourceAzureRMAppService_clientAppAffinityDisabled (103.34s) === RUN TestAccDataSourceAzureRMAppService_siteConfig --- PASS: TestAccDataSourceAzureRMAppService_siteConfig (107.17s) === RUN TestAccDataSourceAzureRMAppService_appSettings --- PASS: TestAccDataSourceAzureRMAppService_appSettings (143.14s) === RUN TestAccDataSourceAzureRMAppService_connectionString --- PASS: TestAccDataSourceAzureRMAppService_connectionString (125.71s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 844.388s ```
| } | ||
|
|
||
| func testAccDataSourceAppService_siteConfig(rInt int, location string) string { | ||
| config := testAccAzureRMAppService_32Bit(rInt, location) |
There was a problem hiding this comment.
Is there a reason for the change of the test name from testAccAzureRMAppService_32Bit -> testAccDataSourceAppService_siteConfig?
There was a problem hiding this comment.
in hindsight probably not, I guess we're checking the siteConfig either way - I've pushed a commit to rename it
|
|
||
| * `dotnet_framework_version` - The version of the .net framework's CLR used in this App Service. | ||
|
|
||
| * `java_version` - The version of Java to use. |
There was a problem hiding this comment.
I think this should be the "Version of Java in use"
|
|
||
| * `java_version` - The version of Java to use. | ||
|
|
||
| * `java_container` - The Java Container to use. |
There was a problem hiding this comment.
Same as above: "The java container in use"
|
|
||
| * `java_container` - The Java Container to use. | ||
|
|
||
| * `java_container_version` - The version of the Java Container to use. |
There was a problem hiding this comment.
Same as above: "The version of the java container in use"
|
|
||
| * `scm_type` - The type of Source Control enabled for this App Service. | ||
|
|
||
| * `use_32_bit_worker_process` - Should the App Service run in 32 bit mode, rather than 64 bit mode? |
There was a problem hiding this comment.
Tense seems incorrect for a datasource.
|
|
||
| * `use_32_bit_worker_process` - Should the App Service run in 32 bit mode, rather than 64 bit mode? | ||
|
|
||
| * `websockets_enabled` - Should WebSockets be enabled? |
There was a problem hiding this comment.
Tense seems incorrect for a datasource.
|
Tests pass (from the previous commit): |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Adding a new Data Source for App Service, since there's use cases for referencing it (e.g. adding a slot / binding a certificate etc)