DNS Zone data source can be retrieved by name only. #1180
Conversation
- Use resource group name if provided, otherwise, use findZone. - findZone will get the resource groups in your subscription and then check the zones in each resource group till it finds the first with a matching dns zone name. - Could not use the zones client ListComplete api call because a Zone does not have any properties related to the Resource Group it is a part of. We have to loop over the list of resource groups and then their zones so that we can have both the zone and the resource group name to return and set on the data source. Fixes hashicorp#1178.
of retrieving the dns zone (given just a name and no rg name).
- Instead, it sets the id of the data source to an empty string and returns.
There was a problem hiding this comment.
Hi @genevieve,
Thank you for opening this PR, LGTM aside from one minor nit that I am just going to update myself (wrapping an error)
Also thank you for formatting the other tests! Its appreciated 🙂
katbyte
force-pushed
the
dnsdata
branch
2 times, most recently
from
7ab6577 to
9fab94e
Compare
|
On further inspection wrapping wasn't needed. Merged master and tests pass: |
|
Hey @genevieve , Just wanted to let you know we have released v1.6.0 of the provider allowing dns zones to be looked up by name only 🙂 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
check the zones in each resource group till it finds the first with
a matching dns zone name.
a Zone does not have any properties related to the Resource Group
it is a part of. We have to loop over the list of resource groups
and then their zones so that we can have both the zone and the resource
group name to return and set on the data source.
Fixes #1178.