Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage Account Network Rules #1334

Merged
merged 5 commits into from
Jun 5, 2018
Merged

Storage Account Network Rules #1334

merged 5 commits into from
Jun 5, 2018

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Jun 1, 2018

This PR adds support for network rules inside of the storage account resource. Addressing #416

=== RUN   TestAccAzureRMStorageAccount_basic
--- PASS: TestAccAzureRMStorageAccount_basic (78.69s)
=== RUN   TestAccAzureRMStorageAccount_importNetworkRules
--- PASS: TestAccAzureRMStorageAccount_importNetworkRules (131.81s)

The existing tests are also passing.

@mbfrahry mbfrahry requested a review from a team June 1, 2018 21:05
katbyte
katbyte approved these changes Jun 5, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mbfrahry mbfrahry merged commit 3c5216f into master Jun 5, 2018
@mbfrahry mbfrahry deleted the f-storage-account-virt-subnet branch June 5, 2018 13:39
@mbfrahry mbfrahry mentioned this pull request Jun 5, 2018
Closed
katbyte added a commit that referenced this pull request Jun 6, 2018
@katbyte
Update CHANGELOG.md to include #1334
09417da
@katbyte katbyte added this to the 1.7.0 milestone Jun 6, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
enhancement service/storage
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mbfrahry @katbyte @tombuildsstuff