Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_servicebus_queue #151

Merged
merged 8 commits into from
Jul 5, 2017
Merged

New Resource: azurerm_servicebus_queue #151

merged 8 commits into from
Jul 5, 2017

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jul 4, 2017

Importing @iljaskevic's PR hashicorp/terraform#14631 from the main Terraform repo. Switched the tests to use formatting methods and addressed @stack72's feedback.

@tombuildsstuff tombuildsstuff requested a review from stack72 July 4, 2017 15:16
@tombuildsstuff tombuildsstuff changed the title New Resource: azurerm_servicebus_queue [WIP] New Resource: azurerm_servicebus_queue Jul 4, 2017
@tombuildsstuff tombuildsstuff changed the title [WIP] New Resource: azurerm_servicebus_queue New Resource: azurerm_servicebus_queue Jul 4, 2017
@tombuildsstuff
Copy link
Contributor Author

Tests still pass after rewriting the git history:

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -timeout 120m -run TestAccAzureRMServiceBusQueue
=== RUN   TestAccAzureRMServiceBusQueue_importBasic
--- PASS: TestAccAzureRMServiceBusQueue_importBasic (208.65s)
=== RUN   TestAccAzureRMServiceBusQueue_basic
--- PASS: TestAccAzureRMServiceBusQueue_basic (220.80s)
=== RUN   TestAccAzureRMServiceBusQueue_update
--- PASS: TestAccAzureRMServiceBusQueue_update (236.82s)
=== RUN   TestAccAzureRMServiceBusQueue_enablePartitioningStandard
--- PASS: TestAccAzureRMServiceBusQueue_enablePartitioningStandard (238.50s)
=== RUN   TestAccAzureRMServiceBusQueue_defaultEnablePartitioningPremium
--- PASS: TestAccAzureRMServiceBusQueue_defaultEnablePartitioningPremium (366.17s)
=== RUN   TestAccAzureRMServiceBusQueue_enableDuplicateDetection
--- PASS: TestAccAzureRMServiceBusQueue_enableDuplicateDetection (236.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1507.266s

@stack72
Copy link
Contributor

stack72 commented Jul 5, 2017

This LGTM! Thanks for this @tombuildsstuff :) Nice to see this ported from the old repo

@stack72 stack72 merged commit cf92ed7 into master Jul 5, 2017
@stack72 stack72 deleted the servicebus-queues branch July 5, 2017 06:54
tombuildsstuff added a commit that referenced this pull request Jul 5, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants