-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose ID of an embedded subnet defined in azurerm_virtual_network #1913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @JunyiYi
Thanks for this PR - if we can fix the documentation issues flagged below this otherwise LGTM 👍
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the sample's been removed this now LGTM 👍
Tests pass (now that #1985 has been temporarily reverted): |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Actually it is hard to reference a specific subnet element in the current implementation because of the hash function. But that is a different story and requires state migration as well. So I just keep it as a small change in this PR.
The PR enables user referencing the subnet ID defined in
azurerm_virtual_network
resource mentioned in issue #666 .Fixes #666