Add resource azurerm_log_analytics_workspace_linked_service

[draggeta]

This resource adds the ability to link OMS Workspaces and Azure Automation Accounts (and possibly others in future) together.

Closes #2080

To do:

• Write resource
• Write acceptance tests
• Write documentation

Example

resource "azurerm_resource_group" "test" {
  name     = "resourceGroup1"
  location = "West Europe"
}

resource "azurerm_automation_account" "test" {
  name                = "automationAccount1"
  location            = "${azurerm_resource_group.test.location}"
  resource_group_name = "${azurerm_resource_group.test.name}"

  sku {
    name = "Basic"
  }

  tags {
    environment = "development"
  }
}

resource "azurerm_log_analytics_workspace" "test" {
  name                = "acctest-01"
  location            = "${azurerm_resource_group.test.location}"
  resource_group_name = "${azurerm_resource_group.test.name}"
  sku                 = "PerGB2018"
  retention_in_days   = 30
}

resource "azurerm_log_analytics_workspace_linked_service" "test" {
  resource_group_name = "${azurerm_resource_group.test.name}"
  workspace_name      = "${azurerm_log_analytics_workspace.test.name}"
  linked_service_name = "automation"

  linked_service_properties {
    resource_id = "${azurerm_automation_account.test.id}"
  }
}

Exports

The following items are also exported

• id: The ID of the resource. This is generated by Azure itself.
• name: The name of the resource. This is generated by Azure itself.

Acceptance tests

PS > go test -timeout 180m -v -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc" `
>> github.com\terraform-providers\terraform-provider-azurerm\azurerm `
>> -run "^TestAccAzureRMLogAnalyticsWorkspaceLinkedService"
=== RUN   TestAccAzureRMLogAnalyticsWorkspaceLinkedService_requiredOnly
--- PASS: TestAccAzureRMLogAnalyticsWorkspaceLinkedService_requiredOnly (85.34s)
=== RUN   TestAccAzureRMLogAnalyticsWorkspaceLinkedService_optionalArguments
--- PASS: TestAccAzureRMLogAnalyticsWorkspaceLinkedService_optionalArguments (83.33s)
=== RUN   TestAccAzureRMLogAnalyticsWorkspaceLinkedService_importRequiredOnly
--- PASS: TestAccAzureRMLogAnalyticsWorkspaceLinkedService_importRequiredOnly (85.92s)
=== RUN   TestAccAzureRMLogAnalyticsWorkspaceLinkedService_importOptionalArguments
--- PASS: TestAccAzureRMLogAnalyticsWorkspaceLinkedService_importOptionalArguments (88.06s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       344.430s

[draggeta]

I am now wondering if it should be renamed to azurerm_log_analytics_workspace_linked_service.

I can't seem to find a clear preference in the resources mentioned in the docs. Some child resources use only their names (e.g.: subnets) and others use the parent resource in the name as well (network interfaces, storage).

Let me know if this should be done. I have this change ready in another branch that I can merge into this.

[katbyte]

Hi @draggeta,

Thank you for the new resource, it mostly LGTM aside from some minor comments I have left inline. The only major issue for me is removing the separate import tests and appending them to the regular ones.

Look forward to getting this merged once those comments are addressed 🙂 thanks!

[katbyte]

I agree the name should probably be azurerm_log_analytics_workspace_linked_service, thoughts @tombuildsstuff?

[draggeta]

I've renamed the resource. Will also change the description up above.

[katbyte]

@draggeta,

Thanks for the quick updates! LGTM now 👍

[katbyte]

tests pass:

[tombuildsstuff]

hi @draggeta

Just to let you know that this has been released as a part of v1.18 of the AzureRM Provider (the full changelog is available here). You can upgrade to this by specifying the version in the provider block (as shown below) and then running terraform init -upgrade

provider "azurerm" {
  version = "=1.18.0"
}

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!