Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including set max_size_bytes #2346

Merged
merged 11 commits into from
Jan 12, 2019
Merged

Including set max_size_bytes #2346

merged 11 commits into from
Jan 12, 2019

Conversation

raphaelquati
Copy link
Contributor

Fix for #2338

@ghost ghost added the size/XS label Nov 17, 2018
@katbyte katbyte self-assigned this Nov 20, 2018
@katbyte katbyte added bug service/mssql Microsoft SQL Server labels Nov 20, 2018
katbyte
katbyte reviewed Nov 21, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raphaelquati,

Thank you for the contribution, and bringing to my attention a defect in the schema here (the elastc_pool_properties block properties should all be part of the top level)

This LGTM except that the tests fail:
screen shot 2018-11-21 at 13 33 49

azurerm/resource_arm_mssql_elasticpool.go Show resolved Hide resolved
katbyte
katbyte requested changes Nov 21, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(forgot to request changes)

@katbyte
Copy link
Collaborator

katbyte commented Dec 21, 2018

Tests are broken on master.

@ghost ghost added the documentation label Jan 11, 2019
@ghost ghost added size/S and removed size/XS labels Jan 11, 2019
WodansSon
WodansSon approved these changes Jan 11, 2019
View reviewed changes
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ghost ghost added size/M and removed size/S labels Jan 12, 2019
@katbyte katbyte added this to the 2.0.0 milestone Jan 12, 2019
@WodansSon
Copy link
Collaborator

image

katbyte
katbyte approved these changes Jan 12, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @jeffreyCline, LGTM now 👍

@katbyte katbyte merged commit 58e8d3c into hashicorp:master Jan 12, 2019
katbyte added a commit that referenced this pull request Jan 12, 2019
@katbyte
Update CHNAGELOG.md to include #2346
1d03bee
@tombuildsstuff tombuildsstuff modified the milestones: 2.0.0, 1.22.0 Jan 21, 2019
@raphaelquati raphaelquati deleted the sqlpooldatasize branch January 28, 2019 14:20
@raphaelquati raphaelquati restored the sqlpooldatasize branch January 28, 2019 14:21
@raphaelquati raphaelquati deleted the sqlpooldatasize branch January 28, 2019 14:55
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WodansSon WodansSon WodansSon approved these changes

@katbyte katbyte katbyte approved these changes

Assignees

@katbyte katbyte

Labels
bug documentation service/mssql Microsoft SQL Server size/M
Projects
None yet
Milestone
v1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@raphaelquati @katbyte @WodansSon @tombuildsstuff