Support for Managed Identity on azurerm_policy_assignment

[olohmann]

This PR adds support for Managed Identity on azurerm_policy_assignment.

Addresses issue #2194

Test Results:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccAzureRMPolicyAssignment -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
?   	github.com/terraform-providers/terraform-provider-azurerm	[no test files]
=== RUN   TestAccAzureRMPolicyAssignment_basic
=== PAUSE TestAccAzureRMPolicyAssignment_basic
=== RUN   TestAccAzureRMPolicyAssignment_deployIfNotExists_policy
=== PAUSE TestAccAzureRMPolicyAssignment_deployIfNotExists_policy
=== RUN   TestAccAzureRMPolicyAssignment_complete
=== PAUSE TestAccAzureRMPolicyAssignment_complete
=== CONT  TestAccAzureRMPolicyAssignment_basic
=== CONT  TestAccAzureRMPolicyAssignment_complete
=== CONT  TestAccAzureRMPolicyAssignment_deployIfNotExists_policy
--- PASS: TestAccAzureRMPolicyAssignment_complete (247.55s)
--- PASS: TestAccAzureRMPolicyAssignment_basic (247.76s)
--- PASS: TestAccAzureRMPolicyAssignment_deployIfNotExists_policy (251.44s)

(fixes #2194)

[tombuildsstuff]

hey @olohmann

Thanks for this PR - I've taken a look and left some comments inline, but this is mostly looking good. The main question I've got is around the design of the schema, which IMO would be better to match the approach used by the Virtual Machine (and other) resources - but most of the other comments are fairly minor 👍

Thanks!

[olohmann]

Again, thanks a lot for the great feedback! Applied requested changes.

Test results:

> $ make testacc TESTARGS='-run=TestAccAzureRMPolicyAssignment'       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccAzureRMPolicyAssignment -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
?   	github.com/terraform-providers/terraform-provider-azurerm	[no test files]
=== RUN   TestAccAzureRMPolicyAssignment_basic
=== PAUSE TestAccAzureRMPolicyAssignment_basic
=== RUN   TestAccAzureRMPolicyAssignment_deployIfNotExists_policy
=== PAUSE TestAccAzureRMPolicyAssignment_deployIfNotExists_policy
=== RUN   TestAccAzureRMPolicyAssignment_complete
=== PAUSE TestAccAzureRMPolicyAssignment_complete
=== CONT  TestAccAzureRMPolicyAssignment_basic
=== CONT  TestAccAzureRMPolicyAssignment_complete
=== CONT  TestAccAzureRMPolicyAssignment_deployIfNotExists_policy
--- PASS: TestAccAzureRMPolicyAssignment_basic (247.32s)
--- PASS: TestAccAzureRMPolicyAssignment_complete (247.38s)
--- PASS: TestAccAzureRMPolicyAssignment_deployIfNotExists_policy (250.14s)

[katbyte]

Hi @olohmann,

I've taken a quick look at it seems you mention UserAssinged in the docs but its not supported in the schema?

[tombuildsstuff]

hey @olohmann

Thanks for pushing those changes - this now LGTM 👍 - I'll kick off the tests shortly

Thanks!

dismissing since changes have been pushed

[tombuildsstuff]

Tests pass - thanks for this @olohmann :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!