Update azure-go-sdk to v24.0.0 and autorest to v11.2.0

[katbyte]

azure-go-sdk v24.0.0 requires an autorest tracing package that was added in v11.2.0

[tombuildsstuff]

providing the tests pass, aside from the one comment this otherwise LGTM; I think we'll also want to update this in github.com/hashicorp/go-azure-helpers too (since we'll be switching to Go Modules in the near future)

[tombuildsstuff]

@katbyte taking a look through the tests, it appears this also requires a downgrade of the Monitor Action Group SDK / API:

* azurerm_monitor_action_group.test: Error creating or updating action group "acctestActionGroup-7372559643033914044" (resource group "acctestRG-7372559643033914044"): insights.ActionGroupsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="NoRegisteredProviderFound" Message="No registered resource provider found for location 'global' and API version '2018-09-01' for type 'actiongroups'. The supported api-versions are '2017-03-01-preview, 2017-04-01, 2018-03-01'. The supported locations are 'global'."

other than that the tests look alright 👍

[katbyte]

So it seems the new version of the SDK isn't calling the correct API. Its currently using 2018-03-01, from the available:

[16:57:07] kt@snowbook:~/hashi/go/src/github.com/Azure/azure-sdk-for-go▸v24$ find . -type d | egrep \/insights\/
./profiles/latest/appinsights/mgmt/insights/insightsapi
./profiles/preview/appinsights/mgmt/insights/insightsapi
./profiles/preview/preview/monitor/mgmt/insights/insightsapi
./profiles/preview/preview/appinsights/insights/insightsapi
./services/appinsights/mgmt/2015-05-01/insights/insightsapi
./services/preview/monitor/mgmt/2018-09-01/insights/insightsapi
./services/preview/monitor/mgmt/2017-05-01-preview/insights/insightsapi
./services/preview/monitor/mgmt/2018-03-01/insights/insightsapi
./services/preview/appinsights/v1/insights/insightsapi

2018-03-01 is giving the error, 2018-09-01 gives the same error, and 2017-05-01-preview lacks a client we now use.

Opened a ticket on the SDK

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!