re-opening #2806 (adjust autoscale limit validation) #2815
Conversation
tombuildsstuff
force-pushed
the
georgespatton
branch
from
3c771e5 to
785bafe
Compare
| CheckDestroy: testCheckAzureRMAutoScaleSettingDestroy, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccAzureRMAutoScaleSetting_capacity(ri, location, 1, 3, 2), |
There was a problem hiding this comment.
We should maybe pass in 0s here to ensure its a valid minimum?
There was a problem hiding this comment.
Agree @katbyte perhaps 0 minimum and 1000 maximum per the Microsoft docs as supported bounds of VMSS instance numbers.
| tier = "Standard" | ||
| capacity = 2 | ||
| capacity = 30 |
There was a problem hiding this comment.
needs confirmation, but I believe this can go down to 1
There was a problem hiding this comment.
It should also be able to goto 0 as well.
katbyte
changed the title
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Including the changes from @georgespatton in #2806 - pushing to that fork broken the PR 🤷♂️
Original PR:
This should fix #2136 as well as #2624 to follow the Azure documentation here: https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/overview
Fixes #2136
Fixes #2624