Enhancement: application_gateway - affinity_cookie_name
#3434
Conversation
mbfrahry
commented
May 14, 2019
•
mbfrahry
commented
There was a problem hiding this comment.
hey @mbfrahry
Thanks for this PR - besides needing a test to confirm a potential bug this otherwise LGTM 👍
Thanks!
| @@ -1527,6 +1533,11 @@ func expandApplicationGatewayBackendHTTPSettings(d *schema.ResourceData, gateway | |||
| setting.ApplicationGatewayBackendHTTPSettingsPropertiesFormat.HostName = utils.String(hostName) | |||
| } | |||
|
|
|||
| affinityCookieName := v["affinity_cookie_name"].(string) | |||
| if affinityCookieName != "" { | |||
| setting.AffinityCookieName = utils.String(affinityCookieName) | |||
There was a problem hiding this comment.
do we not always want to assign this to ensure the value can be removed?
There was a problem hiding this comment.
It looks like it gets removed when you don't pass it in so we're good the way it is!
|
Addressing one of the points of #1576 |
|
This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.28.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
