-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redis_cache datasource #3481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new datasource @sjones-sot.
I've left some comments inline but my main concern is the deviation from the actual resource. Could we just copy the schema there & set the properties in the same way it does?
Thanks!
updated how d.Set's collect properties aligned properties in docs example updated example resource names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @sjones-sot
Thanks for pushing those changes - I've taken a look through and left a few more comments but if we can fix those up this otherwise LGTM 👍
Thanks!
tidied up multiple calls to testLocation() simplified test steps and removed unnecessary func for resource setup updated docs to refer to correct resource
I think everything's addressed, except the item from @katbyte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @sjones-sot
Thanks for pushing those changes - apologies, in my last review I'd missed that the Schema fields weren't Computed
(which is readonly vs Optional
which is setable) - if we can fix those up (and ensure those fields are documented) this otherwise LGTM 👍
Thanks!
Changes being tested currently - so very slow working/testing with redis resources, will tidy and push asap. (Mentioned as I mistakenly pushed some incorrect changes containing Optional items again, sorry) |
Removed MaxItems on readonly resource Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
I have a (possible) bug in this resource/datasource. Accessing the |
outputs to be used for this item without error, even when there are no schedules.
I'm at a loss at why the linter is failing on my last commit(s), would appreciate a hint if anyone can see what I'm missing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @sjones-sot
Thanks for pushing those changes - this now LGTM 👍
dismissing since changes have been pushed
Awesome - thanks for the assistance and reviews :) |
This has been released in version 1.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.30.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Fixes #3432