Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asa sql output #3567

Merged
merged 8 commits into from
Jun 13, 2019
Merged

Asa sql output #3567

merged 8 commits into from
Jun 13, 2019

Conversation

rlekni
Copy link
Contributor

@rlekni rlekni commented May 31, 2019

This PR adds a new output to Azure Stream Analytic jobs.

  • Added new output resource for SQL Databases.
  • Added documentation for the new output.

Ramunas Leknickas added 2 commits May 31, 2019 14:33
@ghost ghost added size/XL and removed size/XXL labels May 31, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @WackPenguin

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can fix up the naming (to clarify that this is specific to a SQL Server Database, and not a generic SQL Database Output) then this is otherwise good to merge👍

Thanks!

azurerm/resource_arm_stream_analytics_output_sql_test.go Outdated Show resolved Hide resolved
azurerm/provider.go Outdated Show resolved Hide resolved
website/docs/r/stream_analytics_output_sql.html.markdown Outdated Show resolved Hide resolved
website/docs/r/stream_analytics_output_sql.html.markdown Outdated Show resolved Hide resolved
website/docs/r/stream_analytics_output_sql.html.markdown Outdated Show resolved Hide resolved
@rlekni
Copy link
Contributor Author

rlekni commented Jun 4, 2019

@tombuildsstuff Thanks for the review. I've made the requested renames. Also renamed some files to be consistent with "mssql".

@ghost ghost removed the waiting-response label Jun 4, 2019
@katbyte katbyte modified the milestones: v1.30.0, v1.31.0 Jun 7, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @WackPenguin

Thanks for pushing those changes - this now LGTM 👍

@katbyte katbyte merged commit 975e2e9 into hashicorp:master Jun 13, 2019
katbyte added a commit that referenced this pull request Jun 13, 2019
@rlekni rlekni deleted the asa-output-sql branch June 13, 2019 10:09
@ghost
Copy link

ghost commented Jun 28, 2019

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants