-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asa sql output #3567
Asa sql output #3567
Conversation
…form-provider-azurerm into asa-output-sql # Conflicts: # azurerm/provider.go # website/azurerm.erb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @WackPenguin
Thanks for this PR :)
Taking a look through this mostly LGTM - if we can fix up the naming (to clarify that this is specific to a SQL Server Database, and not a generic SQL Database Output) then this is otherwise good to merge👍
Thanks!
@tombuildsstuff Thanks for the review. I've made the requested renames. Also renamed some files to be consistent with "mssql". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @WackPenguin
Thanks for pushing those changes - this now LGTM 👍
This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.31.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This PR adds a new output to Azure Stream Analytic jobs.