Feature: azurerm_app_service - filesystem logging can now be set.
#4025
Conversation
|
|
azurerm/helpers/azure/app_service.go
Outdated
| if fileSystemInput.Enabled != nil && *fileSystemInput.Enabled { | ||
| fileSystem = append(fileSystem, fileSystemItem) | ||
|
|
||
| httpLogsItem["file_system"] = fileSystem |
There was a problem hiding this comment.
we need to ensure that httpLogsItem["file_system"] is set to an empty list otherwise to ensure the diff show's correctly
There was a problem hiding this comment.
I set it to an empty list but it caused more issues because it now wants to set http_logs even though nothing is present which causes a diff in Terraform
There was a problem hiding this comment.
if there's no elements specified that should match the diff?
|
@mbfrahry You are the man! :) |
|
@tombuildsstuff, review addressed and tests are passing minus the occasional transient error. |
|
This has been released in version 1.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.33.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #4021