Switching azurerm_storage_blob over to the new Storage SDK
#4179
Conversation
|
|
||
| ctx.wg.Done() | ||
| } | ||
| return resourceArmStorageBlobUpdate(d, meta) |
There was a problem hiding this comment.
(for info) this now calls into Update because the Access Tier might as well be set there, since it needs to be configured after creation anyway
tombuildsstuff
force-pushed
the
f/storage-blob-newsdk
branch
from
a1a5c0f to
d4d4052
Compare
tombuildsstuff
force-pushed
the
f/storage-blob-newsdk
branch
from
d4d4052 to
84c5038
Compare
|
|
||
| chunk := make([]byte, size) | ||
| _, err := page.section.Read(chunk) | ||
| if err != nil && err != io.EOF { |
There was a problem hiding this comment.
These lines could be merged:
| if err != nil && err != io.EOF { | |
| if _, err := page.section.Read(chunk) != nil && err != io.EOF { |
tombuildsstuff
force-pushed
the
f/storage-blob-newsdk
branch
2 times, most recently
from
fb5a557 to
570562b
Compare
tombuildsstuff
changed the title
azurerm_storage_blob over to the new Storage SDKazurerm_storage_blob over to the new Storage SDK
|
I've done some manual testing with large files and this seems fine 👍 |
…o aid refactoring
This reverts commit 9971cce.
…uld do this for us
tombuildsstuff
force-pushed
the
f/storage-blob-newsdk
branch
from
570562b to
91f460c
Compare
|
Travis is failing because a downstream dependency is offline: |
|
This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.34.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Since this is quite a complex resource (in that there's different kinds of blobs) we're going to do this migration to the new SDK in phases. This first PR switches the SDK over to using the new Giovanni Storage SDK but doesn't add support for the new features - nor does it address the open TODO's/add validation/switch the test suite over - which will come in a subsequent PR.
This PR fixes #2245