-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource/Data Source: azurerm_App_Service_Certificate_Order
#4454
Conversation
…vider-azurerm into appCertOrders
…vider-azurerm into appCertOrders
…vider-azurerm into appCertOrders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hund030, thanks for opening this PR. The changes here look great but there are some best practices that we should take into account before merging. This mainly has to do with extra values I don't think are necessary in the resource, doc changes, and struct building in the Create/Update function. We also need to add the docs to the sidebar. I'd put the datasource onehere and the resource one here
These tests also look to be quite expensive so we should a conditional at the top of each test that skips them if an environmental variable isn't set. The below should work for that
|
…vider-azurerm into appCertOrders
…vider-azurerm into appCertOrders
all changes applied, waiting for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for addressing my concerns. This should make it into the next release.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This PR is code implement for issue #2038