-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add APIVersion and APIVersionSetID to import #4993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @sam-cogan
Thanks for this PR - taking a look through this is looking pretty good, if we can fix up the comments (mostly adding back in the missing links) then this otherwise LGTM 👍
Thanks!
@tombuildsstuff I've updated the code to move the validation earlier, but not sure what you meant by "adding back missing links" |
@tombuildsstuff is there anything left that needs doing to get this merged? |
chatting offline: this is fine, I'd confused the comment when writing the PR summary 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this @sam-cogan
This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.39.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Adds the APIVersion and APIVersionSetID to the REST call for creating an API using an import from a file (swagger, WSDL etc.). This fixes the bug in #4985 that would result in creation failing if attempting to create more than 1 version of a single API with the same path.
Fixes #4985