Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name validation for azurerm_role_assignment #5624

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Feb 6, 2020

This PR is the fix of the issue #5543

After investigated, I found the root cause is the property "name" in azurerm_role_assignment the user provided includes character "/" and the client http request url would be appended "AtlasPeeringRoleAssignment/xxxx/xxxx/xxxx". So this request url cannot be found from server side.
After checked, the property "name" should be guid according by the doc(https://docs.microsoft.com/en-us/rest/api/authorization/roleassignments/create).

Fixes #5543

@ghost ghost added the size/XS label Feb 6, 2020
@tombuildsstuff tombuildsstuff added this to the v2.0.0 milestone Feb 17, 2020
@tombuildsstuff tombuildsstuff merged commit c20ebbf into hashicorp:master Feb 17, 2020
tombuildsstuff added a commit that referenced this pull request Feb 17, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to assign role definition to service principal - service returned an error. Status=405
2 participants