New Resource: 'azurerm_storage_account_customer_managed_key' to enable storage account encryption using key vault customer-managed keys #5668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WodansSon
changed the title
WodansSon
changed the title
…form-provider-azurerm into nr_storage_account_cmk
``` $ TF_ACC=1 go test -v ./azurerm/internal/services/storage/tests/ -timeout=60m -run=TestAccAzureRMStorageAccountCustomerManagedKey === RUN TestAccAzureRMStorageAccountCustomerManagedKey_basic === PAUSE TestAccAzureRMStorageAccountCustomerManagedKey_basic === RUN TestAccAzureRMStorageAccountCustomerManagedKey_requiresImport === PAUSE TestAccAzureRMStorageAccountCustomerManagedKey_requiresImport === RUN TestAccAzureRMStorageAccountCustomerManagedKey_updateKey === PAUSE TestAccAzureRMStorageAccountCustomerManagedKey_updateKey === CONT TestAccAzureRMStorageAccountCustomerManagedKey_basic === CONT TestAccAzureRMStorageAccountCustomerManagedKey_updateKey === CONT TestAccAzureRMStorageAccountCustomerManagedKey_requiresImport --- PASS: TestAccAzureRMStorageAccountCustomerManagedKey_requiresImport (381.82s) --- PASS: TestAccAzureRMStorageAccountCustomerManagedKey_updateKey (410.36s) --- PASS: TestAccAzureRMStorageAccountCustomerManagedKey_basic (507.32s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/storage/tests 507.376s ```
tombuildsstuff
approved these changes
Feb 23, 2020
There was a problem hiding this comment.
hey @WodansSon
Thanks for this PR :)
Taking a look through this is looking good - I've left some comments inline which I'm going to push a few commits for to fix - but this otherwise LGTM 👍
Thanks!
azurerm/internal/services/keyvault/resource_arm_key_vault_key.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/keyvault/resource_arm_key_vault_key.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/resource_arm_storage_account_customer_managed_key.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/resource_arm_storage_account_customer_managed_key.go
Show resolved
Hide resolved
azurerm/internal/services/storage/resource_arm_storage_account_customer_managed_key.go
Show resolved
Hide resolved
azurerm/internal/services/storage/resource_arm_storage_account_customer_managed_key.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/resource_arm_storage_account_customer_managed_key.go
Outdated
Show resolved
Hide resolved
|
Ignoring a couple of transitive issues in the API the tests pass:
|
tombuildsstuff
added a commit
that referenced
this pull request
Feb 24, 2020
|
This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.0.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of PR #2046 to new code base.
Updated:
Since
storage accountsare always encrypted by default and the API will now throw an error if you try to set thefileorblobarguments to false. I have removed them from the resource, which is also why I changed the name of the resource, becauseencryption settingsno longer made sense.NOTE: Travis CI checks are failing due to #5344 has not been merged to master as of yet.
Fixes #658
Fixes #3820