Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On metric alert rule creation, the 'autoMitigate' property should be set to true by default #5773

Merged
merged 1 commit into from
Feb 23, 2020

Conversation

sivanguetta
Copy link
Contributor

On metric alert rule creation, the 'autoMitigate' property should be set to true by default.
When 'autoMitigate' is set to false monitor condition not changing from 'Fired' to 'Resolved' automatically as the customers are expected.

@tombuildsstuff tombuildsstuff added this to the v2.0.0 milestone Feb 17, 2020
@sivanguetta
Copy link
Contributor Author

@tombuildsstuff
Thank you for the review:-)
I see that all checks have passed but I can't merge the pull request because I'm not authorized.
How can I merge the PR? what is missing?

@tombuildsstuff tombuildsstuff merged commit 7c40058 into hashicorp:master Feb 23, 2020
tombuildsstuff added a commit that referenced this pull request Feb 23, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants