Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: azurerm_app_configuration #6133

Merged
merged 4 commits into from
Mar 18, 2020

Conversation

tombuildsstuff
Copy link
Contributor

Also refactors the App Configuration Resources whilst I was passing through

Tests pass:

$ TF_ACC=1 go test -v ./azurerm/internal/services/appconfiguration/tests/ -run=TestAppConfigurationDataSource_basic
=== RUN   TestAppConfigurationDataSource_basic
=== PAUSE TestAppConfigurationDataSource_basic
=== CONT  TestAppConfigurationDataSource_basic
--- PASS: TestAppConfigurationDataSource_basic (132.74s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/appconfiguration/tests	132.774s

Fixes #6123

Tests pass:

```
$ TF_ACC=1 go test -v ./azurerm/internal/services/appconfiguration/tests/ -run=TestAppConfigurationDataSource_basic
=== RUN   TestAppConfigurationDataSource_basic
=== PAUSE TestAppConfigurationDataSource_basic
=== CONT  TestAppConfigurationDataSource_basic
--- PASS: TestAppConfigurationDataSource_basic (132.74s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/appconfiguration/tests	132.774s
```

Fixes #6123
@tombuildsstuff
Copy link
Contributor Author

Tests look good:

Screenshot 2020-03-17 at 11 39 43

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 6ddd94d into master Mar 18, 2020
@tombuildsstuff tombuildsstuff deleted the f/app-configuration-data-source branch March 18, 2020 07:52
tombuildsstuff added a commit that referenced this pull request Mar 18, 2020
@ghost
Copy link

ghost commented Mar 18, 2020

This has been released in version 2.2.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.2.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Data resource for Azure App Configuration
2 participants