-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: azurerm_hpc_cache_nfs_target #6191
New resource: azurerm_hpc_cache_nfs_target #6191
Conversation
💤 terraform-provider-azurerm [azurerm_hpc_cache_nfs_target] make testacc TEST="./azurerm/internal/services/storage/tests" TESTARGS="-run='TestAccAzureRMHPCCacheNFSTarget_'"
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
TF_ACC=1 go test ./azurerm/internal/services/storage/tests -v -run='TestAccAzureRMHPCCacheNFSTarget_' -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=a
cc"
=== RUN TestAccAzureRMHPCCacheNFSTarget_basic
=== PAUSE TestAccAzureRMHPCCacheNFSTarget_basic
=== RUN TestAccAzureRMHPCCacheNFSTarget_usageModel
=== PAUSE TestAccAzureRMHPCCacheNFSTarget_usageModel
=== RUN TestAccAzureRMHPCCacheNFSTarget_namespaceJunction
=== PAUSE TestAccAzureRMHPCCacheNFSTarget_namespaceJunction
=== RUN TestAccAzureRMHPCCacheNFSTarget_requiresImport
=== PAUSE TestAccAzureRMHPCCacheNFSTarget_requiresImport
=== CONT TestAccAzureRMHPCCacheNFSTarget_basic
=== CONT TestAccAzureRMHPCCacheNFSTarget_requiresImport
=== CONT TestAccAzureRMHPCCacheNFSTarget_namespaceJunction
=== CONT TestAccAzureRMHPCCacheNFSTarget_usageModel
--- PASS: TestAccAzureRMHPCCacheNFSTarget_requiresImport (2071.76s)
--- PASS: TestAccAzureRMHPCCacheNFSTarget_basic (2142.77s)
--- PASS: TestAccAzureRMHPCCacheNFSTarget_namespaceJunction (2990.85s)
--- PASS: TestAccAzureRMHPCCacheNFSTarget_usageModel (2991.33s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/storage/tests 2991.378s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @magodo, i've left some comments inline that once fixed up this should be good to merge!
azurerm/internal/services/storage/resource_arm_hpc_cache_nfs_target.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/resource_arm_hpc_cache_nfs_target.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/resource_arm_hpc_cache_nfs_target.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/resource_arm_hpc_cache_nfs_target.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/resource_arm_hpc_cache_nfs_target.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/tests/resource_arm_hpc_cache_nfs_target_test.go
Show resolved
Hide resolved
azurerm/internal/services/storage/tests/resource_arm_hpc_cache_nfs_target_test.go
Outdated
Show resolved
Hide resolved
Review [Link](hashicorp#6191 (review))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @magodo! LGTM 👍
This has been released in version 2.4.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.4.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This PR together with the #6035 (merged) address #6014
Fixes #6014