-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Data Source: azurerm_network_security_group
#623
Conversation
``` $ acctests azurerm TestAccDataSourceAzureRMNetworkSecurityGroup_ === RUN TestAccDataSourceAzureRMNetworkSecurityGroup_basic --- PASS: TestAccDataSourceAzureRMNetworkSecurityGroup_basic (85.37s) === RUN TestAccDataSourceAzureRMNetworkSecurityGroup_rules --- PASS: TestAccDataSourceAzureRMNetworkSecurityGroup_rules (81.30s) === RUN TestAccDataSourceAzureRMNetworkSecurityGroup_tags --- PASS: TestAccDataSourceAzureRMNetworkSecurityGroup_tags (83.74s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 250.432s ```
|
||
* `priority` - The priority of the rule | ||
|
||
* `direction` - The direction specifies if rule will be evaluated on incoming or outgoing traffic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, but is there any reason for all the newlines between each attribute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not particularly - I copied this over from the resource docs and updated the descriptions (since the schema's the same) - it's mostly just to help readability when writing docs (this doesn't impact the rendering on the website at all). I can consolidate it if you want?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chatted offline about this, this is 👍 to merge - merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
As proposed in #621.
Tests pass: