New data source: azurerm_policy_set_definition
#6305
Conversation
There was a problem hiding this comment.
Thanks for the pr @ArcturusZhang,
Overall this looks great, i've left some comments inline that once addressed this should be good to go!
azurerm/internal/services/policy/data_source_policy_set_definition.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/policy/data_source_policy_set_definition.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/policy/data_source_policy_set_definition.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/policy/data_source_policy_set_definition.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/policy/tests/resource_arm_policy_remediation_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/policy/tests/resource_arm_policy_set_definition_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/policy/tests/resource_arm_policy_set_definition_test.go
Outdated
Show resolved
Hide resolved
|
Hi @katbyte I have made some changes according to your comments, please have a look, thanks! |
There was a problem hiding this comment.
Thanks for the changes @ArcturusZhang, once the merge conflicts are resolved this should be good to go!
…-set-definition-data-source
…ub.com:ArcturusZhang/terraform-provider-azurerm into add-name-for-policy-set-definition-data-source
|
Hi @katbyte I have resolved the merge conflict, please have a look thanks |
ArcturusZhang
deleted the
add-name-for-policy-set-definition-data-source
branch
|
This has been released in version 2.6.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.6.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
This PR adds data source
azurerm_policy_set_definition, and also resolves some minor issues in thepolicyservice.Fixes #6251