Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_sql_server - support for connection_policy property #6438

Merged
merged 3 commits into from
Apr 10, 2020

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Apr 10, 2020

No description provided.

@katbyte katbyte added enhancement service/mssql Microsoft SQL Server labels Apr 10, 2020
@katbyte katbyte added this to the v2.6.0 milestone Apr 10, 2020
@katbyte katbyte requested a review from a team April 10, 2020 05:35
@ghost ghost added size/M and removed size/L labels Apr 10, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looking for a test!

@@ -71,9 +71,15 @@ func resourceArmSqlServer() *schema.Resource {
Sensitive: true,
},

"fully_qualified_domain_name": {
"connection_policy": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to confirm this works?

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when a test gets added

@katbyte katbyte merged commit d8520bf into master Apr 10, 2020
@katbyte katbyte deleted the kt/sql-connection-please branch April 10, 2020 20:53
katbyte added a commit that referenced this pull request Apr 10, 2020
@ghost
Copy link

ghost commented Apr 16, 2020

This has been released in version 2.6.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.6.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants