Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/azurerm_linux|windows_virtual_machine_scale_set - updating do_not_run_extensions_on_overprovisioned_machines #6917

Merged

Conversation

ArcturusZhang
Copy link
Contributor

Fixes #6830

@ghost ghost added the size/M label May 14, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.10.0 milestone May 14, 2020
@tombuildsstuff tombuildsstuff changed the title Update resource azurerm_linux|windows_virtual_machine_scale_set - Fix #6830 r/azurerm_linux|windows_virtual_machine_scale_set - updating do_not_run_extensions_on_overprovisioned_machines May 14, 2020
@tombuildsstuff
Copy link
Contributor

Ignoring a few 429's from running too many tests at once - the tests look good 👍

@tombuildsstuff tombuildsstuff merged commit 7968f49 into hashicorp:master May 14, 2020
tombuildsstuff added a commit that referenced this pull request May 14, 2020
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ArcturusZhang ArcturusZhang deleted the fix-vmss-overprovisioned branch May 15, 2020 10:31
@ghost
Copy link

ghost commented Jun 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DoNotRunExtensionsOnOverprovisionedVMs wont work
2 participants