New Resources: `azurerm_app_service_slot` & `azurerm_app_service_active_slot` #818

WodansSon · 2018-02-09T23:42:39Z

This PR adds support for App Service Slot and Active Slot features to the Azure Terraform Provider.

Added Resources

resource_arm_app_service_active_slot
resource_arm_app_service_active_slot_test
resource_arm_app_service_slot
resource_arm_app_service_slot_test
app_service_slot.html.markdown
app_service_active_slot.html.markdown

Updated Resources

azurerm.erb
provider

Test Results

… these service plans, updated documentation with this information as well.

metacpp · 2018-02-10T01:16:07Z

@tombuildsstuff this PR has been verified by @jeffreyCline in our own environment. See test results link to Gist.

metacpp

LGTM

tombuildsstuff

hey @jeffreyCline

Thanks for this PR - I've taken a look through and left some comments inline, but this is looking really good. Most of the comments are really minor (whitespace) - the main thing we should change is updating the source_slot_name field to app_service_slot_name for consistency within Terraform - otherwise this looks good 👍

Thanks!

tombuildsstuff · 2018-02-10T01:33:03Z

website/docs/r/app_service_active_slot.html.markdown

+
+* `resource_group_name` - (Required) The name of the resource group in which to create the App Service Slot component.
+
+* `app_service_name` - (Required) The name of the App Service within which to create the App Service Slot.  Changing this forces a new resource to be created.


Can we make this (Required) The name of the App Service within which the Slot exists. Changing this forces a new resource to be created.?

tombuildsstuff · 2018-02-10T01:33:11Z

website/docs/r/app_service_active_slot.html.markdown

+
+The following arguments are supported:
+
+* `resource_group_name` - (Required) The name of the resource group in which to create the App Service Slot component.


Can we make this (Required) The name of the Resource Group in which the App Service exists. Changing this forces a new resource to be created.?

tombuildsstuff · 2018-02-10T01:33:29Z

website/docs/r/app_service_active_slot.html.markdown

+
+* `app_service_name` - (Required) The name of the App Service within which to create the App Service Slot.  Changing this forces a new resource to be created.
+
+* `preserve_vnet` - (Required) `true` to preserve Virtual Network to the slot during swap; otherwise, `false`.


🤔 is there a use-case where we wouldn't want this to be true? I'm wondering if we default it to true and don't expose that for now?

I'm not sure, but it is exposed in models.go CsmSlotEntity struct so I exposed it to Terraform.

taking a look at the Azure CLI and the Portal - neither of these expose this value; as such I think we can safely default this value to true for the moment and not expose it :)

Ok, sounds good... I make that change.

tombuildsstuff · 2018-02-10T01:33:47Z

website/docs/r/app_service_active_slot.html.markdown

+
+* `preserve_vnet` - (Required) `true` to preserve Virtual Network to the slot during swap; otherwise, `false`.
+
+* `source_slot_name` - (Required) Source deployment slot for the swap operation.


I think it might be worth naming this field app_service_slot_name?

tombuildsstuff · 2018-02-10T01:36:07Z

website/docs/r/app_service_active_slot.html.markdown

+
+# azurerm_app_service_slot
+
+Swaps an App Service Slot (within an App Service) with the Production slot.


Can we make this: Promotes an App Service Slot to Production within an App Service

tombuildsstuff · 2018-02-10T14:02:35Z

azurerm/resource_arm_app_service_slot_test.go

+  location            = "${azurerm_resource_group.test.location}"
+  resource_group_name = "${azurerm_resource_group.test.name}"
+	app_service_plan_id = "${azurerm_app_service_plan.test.id}"
+	app_service_name    = "${azurerm_app_service.test.name}"


minor could we sort out the spacing here?

tombuildsstuff · 2018-02-10T14:02:43Z

azurerm/resource_arm_app_service_slot_test.go

+	location            = "${azurerm_resource_group.test.location}"
+	resource_group_name = "${azurerm_resource_group.test.name}"
+	app_service_plan_id = "${azurerm_app_service_plan.test.id}"
+	app_service_name    = "${azurerm_app_service.test.name}"


minor could we sort out the spacing here?

tombuildsstuff · 2018-02-10T14:05:07Z

azurerm/resource_arm_app_service_active_slot_test.go

+		sku {
+		tier = "Standard"
+		size = "S1"
+		}


minor could we sort out the spacing here?

tombuildsstuff · 2018-02-10T14:05:12Z

azurerm/resource_arm_app_service_active_slot_test.go

+		sku {
+		tier = "Standard"
+		size = "S1"
+		}


minor could we sort out the spacing here?

tombuildsstuff · 2018-02-10T14:05:24Z

azurerm/resource_arm_app_service_active_slot_test.go

+		sku {
+		tier = "Standard"
+		size = "S1"
+		}


minor could we sort out the spacing here?

…te function

(we generally use `{resourcename}1` so it's easier to tell what's an example)

tombuildsstuff

hey @jeffreyCline

Thanks for pushing those updates - I've taken a look through and pushed a couple of updates to fix some documentation nits (I hope you don't mind!), but this otherwise LGTM 👍

Thanks!

tombuildsstuff · 2018-02-13T02:28:44Z

All the App Service prefixed tests pass:

ghost · 2020-03-31T15:34:19Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

Jeffrey Cline and others added 6 commits February 6, 2018 16:02

Expose app service slot

993085f

Docs and Import test

dcc18dd

Free tier test

cc5aa99

WIP Expose slot and active slot with tests and documentation.

d810f72

Fixed issue with TestAccAzureRMAppServiceSlot_clientAffinityEnabled test

696fb61

Removed shared and free tier tests because slots are not supported in…

27e11b2

… these service plans, updated documentation with this information as well.

WodansSon requested review from tombuildsstuff, metacpp, mbfrahry and JunyiYi February 9, 2018 23:42

metacpp added the feature label Feb 9, 2018

metacpp added this to the 1.1.3 milestone Feb 10, 2018

tombuildsstuff added new-resource service/app-service and removed feature labels Feb 10, 2018

metacpp approved these changes Feb 10, 2018

View reviewed changes

tombuildsstuff reviewed Feb 10, 2018

View reviewed changes

thatfrankdev mentioned this pull request Feb 10, 2018

Feature Request: App Services (Deployment) Slots #776

Closed

tombuildsstuff added the waiting-response label Feb 12, 2018

Jeffrey Cline and others added 4 commits February 12, 2018 16:28

Addressed comments in PR, converted all tabs to 2 spaces.

abd2943

Fix format failure

d460bff

Removed preserve_vnet schema entry and hardcode value to true in crea…

8db8540

…te function

Removed preserve_vnet from test cases

d71a21f

tombuildsstuff removed the waiting-response label Feb 13, 2018

tombuildsstuff modified the milestones: 1.1.3, 1.1.2 Feb 13, 2018

tombuildsstuff changed the title ~~Add Support for App Service Slot and Active Slot~~ New Resources: azurerm_app_service_slot & azurerm_app_service_active_slot Feb 13, 2018

tombuildsstuff added 2 commits February 12, 2018 18:24

Removing preserve_vnet from the example

e4685f0

Updating the description for app_service_slot_name

90f41ac

Updating the import URI to follow conventions

12592ee

(we generally use `{resourcename}1` so it's easier to tell what's an example)

tombuildsstuff approved these changes Feb 13, 2018

View reviewed changes

tombuildsstuff merged commit cebe9f3 into master Feb 13, 2018

tombuildsstuff deleted the f-app-service-slot branch February 13, 2018 02:33

tombuildsstuff added a commit that referenced this pull request Feb 13, 2018

Updating to include #818

b2076d8

ghost locked and limited conversation to collaborators Mar 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resources: `azurerm_app_service_slot` & `azurerm_app_service_active_slot` #818

New Resources: `azurerm_app_service_slot` & `azurerm_app_service_active_slot` #818

WodansSon commented Feb 9, 2018 •

edited

Loading

metacpp commented Feb 10, 2018

metacpp left a comment

tombuildsstuff left a comment

tombuildsstuff Feb 10, 2018

tombuildsstuff Feb 10, 2018

tombuildsstuff Feb 10, 2018

WodansSon Feb 12, 2018

tombuildsstuff Feb 12, 2018

WodansSon Feb 13, 2018

tombuildsstuff Feb 10, 2018

tombuildsstuff Feb 10, 2018

tombuildsstuff Feb 10, 2018

tombuildsstuff Feb 10, 2018

tombuildsstuff Feb 10, 2018

tombuildsstuff Feb 10, 2018

tombuildsstuff Feb 10, 2018

tombuildsstuff left a comment

tombuildsstuff commented Feb 13, 2018 •

edited

Loading

ghost commented Mar 31, 2020


		* `resource_group_name` - (Required) The name of the resource group in which to create the App Service Slot component.

		* `app_service_name` - (Required) The name of the App Service within which to create the App Service Slot. Changing this forces a new resource to be created.


		The following arguments are supported:

		* `resource_group_name` - (Required) The name of the resource group in which to create the App Service Slot component.


		* `app_service_name` - (Required) The name of the App Service within which to create the App Service Slot. Changing this forces a new resource to be created.

		* `preserve_vnet` - (Required) `true` to preserve Virtual Network to the slot during swap; otherwise, `false`.


		* `preserve_vnet` - (Required) `true` to preserve Virtual Network to the slot during swap; otherwise, `false`.

		* `source_slot_name` - (Required) Source deployment slot for the swap operation.


		# azurerm_app_service_slot

		Swaps an App Service Slot (within an App Service) with the Production slot.

New Resources: azurerm_app_service_slot & azurerm_app_service_active_slot #818

New Resources: azurerm_app_service_slot & azurerm_app_service_active_slot #818

Conversation

WodansSon commented Feb 9, 2018 • edited Loading

metacpp commented Feb 10, 2018

metacpp left a comment

Choose a reason for hiding this comment

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tombuildsstuff left a comment

Choose a reason for hiding this comment

tombuildsstuff commented Feb 13, 2018 • edited Loading

ghost commented Mar 31, 2020

New Resources: `azurerm_app_service_slot` & `azurerm_app_service_active_slot` #818

New Resources: `azurerm_app_service_slot` & `azurerm_app_service_active_slot` #818

WodansSon commented Feb 9, 2018 •

edited

Loading

tombuildsstuff commented Feb 13, 2018 •

edited

Loading