Adding private_cluster

[lenartj]

This is to implement #1174, support for Private Clusters on Google Kubernetes Engine (Container Engine; GKE).

• Announcement about the feature
• Setting up a Private Cluster (essential document!)
• Added variables private_cluster (bool) and master_ipv4_cidr (cidr) under the google_container _cluster
• Example usage in 66bf538

I am not familiar with the codebase, please be patient :-)

@danawillow, can you look at this please?

[danawillow]

Thanks @lenartj, this looks great!

I ran the tests and they failed because of the interpolation typo I commented on. Fixing that led to a different bug I found. If you wouldn't mind just adding this:

	if len(c.CidrBlocks) == 0 {
		return nil
	}

to the beginning of flattenMasterAuthorizedNetworksConfig that'll fix it.

Also, feel free to run the tests yourself- there are some instructions at https://github.com/terraform-providers/terraform-provider-google/blob/master/.github/CONTRIBUTING.md#tests. Let me know if you have any questions!

[danawillow]

Let's actually call this master_ipv4_cider_block to be consistent with the cidr_blocks attribute from master_authorized_networks_config

[lenartj]

Sure, cider sounds good :-)

[danawillow]

think you meant container_subnetwork :)
(and the line below)

[lenartj]

Fixed

[danawillow]

I ran the tests, and it looks like private_ip_google_access is getting enabled automatically on the subnetwork when the cluster is created in it. Mind just setting that to true from the beginning?

[lenartj]

Added

[danawillow]

The import tests won't actually work for this, because we don't have import support for beta attributes yet. You can just set ImportStateVerifyIgnore for the new fields.

[lenartj]

Fixed

[lenartj]

$ make testacc TEST=./google TESTARGS='-run=TestAccContainerCluster_withPrivateCluster'                           
==> Checking that code complies with gofmt requirements...                                                                                                                                                              
TF_ACC=1 go test ./google -v -run=TestAccContainerCluster_withPrivateCluster -timeout 120m                                                                                                                      
=== RUN   TestAccContainerCluster_withPrivateCluster                                                                                           
=== PAUSE TestAccContainerCluster_withPrivateCluster                                                                                                                         
=== CONT  TestAccContainerCluster_withPrivateCluster                                                                                                                            
--- PASS: TestAccContainerCluster_withPrivateCluster (423.94s)
PASS                                                                          
ok      github.com/terraform-providers/terraform-provider-google/google 423.951s

[lenartj]

Thanks for the comments @danawillow, fixed it up. Apologies for not running the tests, I had a really bad internet connection at sea ⛴ when I wrote this

[danawillow]

Thanks @lenartj, looks good! And lol good catch about the cider thing, thanks for not taking my suggestion too literally :)

[lenartj]

Resolved #1174

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!