Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to retry cloud functions on failure #1452

Merged
merged 1 commit into from
May 9, 2018

Conversation

danawillow
Copy link
Contributor

Fixes #1164.

I opted to top-level this because we already have precedent in this resource for top-leveling instead of nesting, but I could be persuaded otherwise. Also, the API for this is just to send an empty Retry object if you want to enable retries, which would lead to tf configs that look like this if we kept to the API:

resource "google_cloudfunctions_function" "function" {
  name = "whatever"
  // other properties
  failure_policy {
    retry {
    }
  }
}

since right now, the only thing in a failure policy that can be set is retry, which has no attributes of its own.
(see https://cloud.google.com/functions/docs/reference/rest/v1/projects.locations.functions)

@danawillow danawillow requested a review from nat-henderson May 8, 2018 20:52
@danawillow danawillow merged commit 08b5804 into hashicorp:master May 9, 2018
@danawillow danawillow deleted the is-1164 branch May 9, 2018 20:57
@Farhie
Copy link

Farhie commented May 9, 2018

Awesome, thanks @danawillow!

chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
@ghost
Copy link

ghost commented Nov 18, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants