Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read method + test/document import for google_compute_health_check #155

Merged
merged 2 commits into from
Jun 26, 2017

Conversation

rileykarson
Copy link
Collaborator

  • Make google_compute_health_check refresh the HealthCheck blocks on Read.
  • Test importing a google_compute_health_check with each block type
  • Document importing a google_compute_health_check

Fixes #134.

@stack72
Copy link
Contributor

stack72 commented Jun 26, 2017

this LGTM thanks for this @rileykarson :)

% make testacc TEST=./google TESTARGS='-run=TestAccComputeHealthCheck_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccComputeHealthCheck_ -timeout 120m
=== RUN   TestAccComputeHealthCheck_importBasicHttp
--- PASS: TestAccComputeHealthCheck_importBasicHttp (24.04s)
=== RUN   TestAccComputeHealthCheck_importBasicHttps
--- PASS: TestAccComputeHealthCheck_importBasicHttps (23.14s)
=== RUN   TestAccComputeHealthCheck_importBasicTcp
--- PASS: TestAccComputeHealthCheck_importBasicTcp (23.99s)
=== RUN   TestAccComputeHealthCheck_importBasicSsl
--- PASS: TestAccComputeHealthCheck_importBasicSsl (23.06s)
=== RUN   TestAccComputeHealthCheck_tcp
--- PASS: TestAccComputeHealthCheck_tcp (23.71s)
=== RUN   TestAccComputeHealthCheck_tcp_update
--- PASS: TestAccComputeHealthCheck_tcp_update (35.30s)
=== RUN   TestAccComputeHealthCheck_ssl
--- PASS: TestAccComputeHealthCheck_ssl (23.41s)
=== RUN   TestAccComputeHealthCheck_http
--- PASS: TestAccComputeHealthCheck_http (23.43s)
=== RUN   TestAccComputeHealthCheck_https
--- PASS: TestAccComputeHealthCheck_https (23.05s)
=== RUN   TestAccComputeHealthCheck_tcpAndSsl_shouldFail
--- PASS: TestAccComputeHealthCheck_tcpAndSsl_shouldFail (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	223.152s

@stack72 stack72 merged commit e5267f2 into hashicorp:master Jun 26, 2017
pdecat pushed a commit to pdecat/terraform-provider-google that referenced this pull request Jun 29, 2017
hashicorp#155)

* Read health check block + add import support to google_compute_health_check.

* Updated google_compute_health_check documentation.
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
hashicorp#155)

* Read health check block + add import support to google_compute_health_check.

* Updated google_compute_health_check documentation.
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
Add nil check to fix panic in storage bucket.
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test + Document google_compute_health_check import
2 participants