Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject disk shrinkage on SQL instances #1684

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

nat-henderson
Copy link
Contributor

Fixes #1612.

Tested with a local example, which did require ForceNew when the disk shrank but updated an increased disk size without trouble. Running cloud tests now.

@nat-henderson
Copy link
Contributor Author

All pass, except

--- FAIL: TestAccSqlDatabaseInstance_basic3 (641.74s)
        testing.go:518: Step 0 error: Error applying: 1 error(s) occurred:

                * google_sql_database_instance.instance: 1 error(s) occurred:

                * google_sql_database_instance.instance: Error, failed to delete default 'root'@'*' user, but the database was created successfully: 

Which I think is a flake, but I'll rerun to be sure.

@nat-henderson
Copy link
Contributor Author

Yep, it passed on the second try. :) This is ready to merge.

@paddycarver paddycarver merged commit fe0950d into hashicorp:master Jun 22, 2018
@ghost
Copy link

ghost commented Nov 17, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants