Make sure TypeList keys still have empty values

[emilymye]

• If key is not set in ResourceData, diff will not trigger
• Moved nil checks into flatten methods since this matches generated resources and also cleans Read() a bit
• Moved masterAuth logic into a flatten method

Fixes #1675 and also possibly other things

[nat-henderson]

That definitely fixes other things! Did you run the tests? If they all still pass this looks great.

[paddycarver]

Could we check the error on these? Complex types with d.Set can sometimes get tricky. :/

[emilymye]

I ran most of the tests (in batches because cluster limits and I haven't changed that quota yet)

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v --run="TestAccContainerCluster_withM" -timeout 120m
=== RUN TestAccContainerCluster_withMasterAuthConfig
=== PAUSE TestAccContainerCluster_withMasterAuthConfig
=== RUN TestAccContainerCluster_withMasterAuthorizedNetworksConfig
=== PAUSE TestAccContainerCluster_withMasterAuthorizedNetworksConfig
=== RUN TestAccContainerCluster_withMaintenanceWindow
=== PAUSE TestAccContainerCluster_withMaintenanceWindow
=== CONT TestAccContainerCluster_withMasterAuthConfig
=== CONT TestAccContainerCluster_withMaintenanceWindow
=== CONT TestAccContainerCluster_withMasterAuthorizedNetworksConfig
--- PASS: TestAccContainerCluster_withMasterAuthConfig (306.09s)
--- PASS: TestAccContainerCluster_withMaintenanceWindow (309.49s)
--- PASS: TestAccContainerCluster_withMasterAuthorizedNetworksConfig (313.31s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google313.498s
TF_ACC=1 go test ./google -v --run="TestAccContainerCluster_basic" -timeout 120m
=== RUN TestAccContainerCluster_basic
=== PAUSE TestAccContainerCluster_basic
=== CONT TestAccContainerCluster_basic
--- PASS: TestAccContainerCluster_basic (276.99s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google277.155s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!